prosody
62a7042e0771

Find changesets by keywords by author, files, the commit message, revision number or hash, or revset expression.

Software / code / prosody

Changeset

10385:62a7042e0771 0.11

net.resolvers: Abort on hostnames not passing IDNA validation Prevents error on trying to use nil. Needs better error reporting in the future.
author Kim Alvefur <zash@zash.se>
date Sat, 02 Nov 2019 19:36:19 +0100
parents 10384:94c9c574cd8a
children 10386:cf93a951da37 10389:dbb8dae58265
files net/resolvers/basic.lua net/resolvers/service.lua
diffstat 2 files changed, 10 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/net/resolvers/basic.lua	Sat Nov 02 19:24:26 2019 +0100
+++ b/net/resolvers/basic.lua	Sat Nov 02 19:36:19 2019 +0100
@@ -18,6 +18,11 @@
 		return;
 	end
 
+	if not self.hostname then
+		-- FIXME report IDNA error
+		cb(nil);
+	end
+
 	local targets = {};
 	local n = 2;
 	local function ready()
--- a/net/resolvers/service.lua	Sat Nov 02 19:24:26 2019 +0100
+++ b/net/resolvers/service.lua	Sat Nov 02 19:36:19 2019 +0100
@@ -25,6 +25,11 @@
 		return;
 	end
 
+	if not self.hostname then
+		-- FIXME report IDNA error
+		cb(nil);
+	end
+
 	local targets = {};
 	local function ready()
 		self.targets = targets;