Software / code / prosody
Changeset
11717:605484fc1c62
mod_pubsub: Normalize 'publisher' JID
All the XEP-0060 examples have the publisher attribute set to a bare
JID, but the text does allow it to be the full JID.
Since mod_pubsub is more likely used for open nodes that anyone can
subscribe to it makes sense to not leak the full JIDs. This is also
disabled by defaults.
In mod_pep on the other hand it might make sense to have the full JID
since that data is more likely to be broadcast to contacts which are
already somewhat trusted.
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Sun, 25 Jul 2021 14:01:45 +0200 |
| parents | 11716:30f1e826cc95 |
| children | 11718:d79f5431f31b |
| files | plugins/mod_pubsub/mod_pubsub.lua |
| diffstat | 1 files changed, 2 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/plugins/mod_pubsub/mod_pubsub.lua Sun Jul 25 13:52:52 2021 +0200 +++ b/plugins/mod_pubsub/mod_pubsub.lua Sun Jul 25 14:01:45 2021 +0200 @@ -57,7 +57,7 @@ return lib_pubsub.archive_itemstore(archive, max_items, nil, node_name); end -function simple_broadcast(kind, node, jids, item, actor, node_obj) +function simple_broadcast(kind, node, jids, item, actor, node_obj, service) if node_obj then if node_obj.config["notify_"..kind] == false then return; @@ -75,7 +75,7 @@ item:maptags(function () return nil; end); end if expose_publisher and actor then - item.attr.publisher = actor + item.attr.publisher = service.config.normalize_jid(actor); end end end
