Software `/` code `/` prosody

Annotate

plugins/mod_bosh.lua @ 7653:17e42f793341

mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use

author	Matthew Wild <mwild1@gmail.com>
date	Fri, 02 Sep 2016 22:13:54 +0100
parent	7652:7cc3d6c764ce
child	7654:b40776ee2aef
child	7659:449de852cf38

rev	line source
1522 569d58d21612 Add copyright header to those files missing one Matthew Wild <mwild1@gmail.com> parents: 1112 diff changeset	1 -- Prosody IM
2923 b7049746bd29 Update copyright headers for 2010 Matthew Wild <mwild1@gmail.com> parents: 2099 diff changeset	2 -- Copyright (C) 2008-2010 Matthew Wild
b7049746bd29 Update copyright headers for 2010 Matthew Wild <mwild1@gmail.com> parents: 2099 diff changeset	3 -- Copyright (C) 2008-2010 Waqas Hussain
5634 7298c9bbb30f mod_bosh: Some very minor whitespace/layout fixes Matthew Wild <mwild1@gmail.com> parents: 5188 diff changeset	4 --
1522 569d58d21612 Add copyright header to those files missing one Matthew Wild <mwild1@gmail.com> parents: 1112 diff changeset	5 -- This project is MIT/X11 licensed. Please see the
569d58d21612 Add copyright header to those files missing one Matthew Wild <mwild1@gmail.com> parents: 1112 diff changeset	6 -- COPYING file in the source package for more information.
569d58d21612 Add copyright header to those files missing one Matthew Wild <mwild1@gmail.com> parents: 1112 diff changeset	7 --
569d58d21612 Add copyright header to those files missing one Matthew Wild <mwild1@gmail.com> parents: 1112 diff changeset	8
4623 403b56b78018 mod_posix, mod_bosh, mod_admin_telnet: Use module:set_global() Kim Alvefur <zash@zash.se> parents: 4457 diff changeset	9 module:set_global(); -- Global module
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	10
1042 a3d77353c18a mod_: Fix a load of global accesses Matthew Wild <mwild1@gmail.com>* parents: 947 diff changeset	11 local hosts = _G.hosts;
3707 79f62694d36e mod_bosh: Switch to util.xmppstream from xmlhandlers Matthew Wild <mwild1@gmail.com> parents: 3684 diff changeset	12 local new_xmpp_stream = require "util.xmppstream".new;
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	13 local sm = require "core.sessionmanager";
679 9506bf204b1a Numerous BOSH improvements... handle client disconnects, either explicit or implicit through inactivity; allow specifying BOSH default parameters through config; fix to prevent prematurely closing request connections in some cases, before they were replied to Matthew Wild <mwild1@gmail.com> parents: 660 diff changeset	14 local sm_destroy_session = sm.destroy_session;
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	15 local new_uuid = require "util.uuid".generate;
5013 ab693eea0869 mod_admin_adhoc, mod_admin_telnet, mod_bosh, mod_c2s, mod_component, mod_pep, mod_presence, mod_roster, mod_s2s: Import core_post_stanza from the global prosody table. Kim Alvefur <zash@zash.se> parents: 4998 diff changeset	16 local core_process_stanza = prosody.core_process_stanza;
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	17 local st = require "util.stanza";
1109 bb21eb3cd364 mod_bosh: Give BOSH sessions a logger (thanks Florob) Matthew Wild <mwild1@gmail.com> parents: 1049 diff changeset	18 local logger = require "util.logger";
bb21eb3cd364 mod_bosh: Give BOSH sessions a logger (thanks Florob) Matthew Wild <mwild1@gmail.com> parents: 1049 diff changeset	19 local log = logger.init("mod_bosh");
5187 d71f731e8fe4 mod_bosh: Add support for stanza filters to BOSH sessions (needed by some plugins) Matthew Wild <mwild1@gmail.com> parents: 5185 diff changeset	20 local initialize_filters = require "util.filters".initialize;
5185 ca30b21946ef mod_bosh: Add bosh_max_wait config option, to limit the amount of time a client can request for the server to hold open requests Matthew Wild <mwild1@gmail.com> parents: 5179 diff changeset	21 local math_min = math.min;
5727 372ecf3630cf mod_bosh: pcall() core_process_stanza per stanza, to bring in line with other listeners. This ensures that stanzas following a traceback-causing stanza in a request will still be processed (as would happen on normal c2s). Matthew Wild <mwild1@gmail.com> parents: 5726 diff changeset	22 local xpcall, tostring, type = xpcall, tostring, type;
372ecf3630cf mod_bosh: pcall() core_process_stanza per stanza, to bring in line with other listeners. This ensures that stanzas following a traceback-causing stanza in a request will still be processed (as would happen on normal c2s). Matthew Wild <mwild1@gmail.com> parents: 5726 diff changeset	23 local traceback = debug.traceback;
7378 d15cfe8627ad mod_bosh: Validate 'to' host (see #343) Kim Alvefur <zash@zash.se> parents: 7377 diff changeset	24 local nameprep = require "util.encodings".stringprep.nameprep;
1665 2c72b725384e mod_bosh: Strip BOSH namespace from stanzas to allow for some clients which may send them without the correct xmlns Matthew Wild <mwild1@gmail.com> parents: 1664 diff changeset	25
3448 0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	26 local xmlns_streams = "http://etherx.jabber.org/streams";
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	27 local xmlns_xmpp_streams = "urn:ietf:params:xml:ns:xmpp-streams";
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	28 local xmlns_bosh = "http://jabber.org/protocol/httpbind"; -- (hard-coded into a literal in session.send)
3449 0a74ce129a06 mod_bosh: Small change to use variable instead of hard-coded xmlns Matthew Wild <mwild1@gmail.com> parents: 3448 diff changeset	29
0a74ce129a06 mod_bosh: Small change to use variable instead of hard-coded xmlns Matthew Wild <mwild1@gmail.com> parents: 3448 diff changeset	30 local stream_callbacks = {
0a74ce129a06 mod_bosh: Small change to use variable instead of hard-coded xmlns Matthew Wild <mwild1@gmail.com> parents: 3448 diff changeset	31 stream_ns = xmlns_bosh, stream_tag = "body", default_ns = "jabber:client" };
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	32
7653 17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	33 -- These constants are implicitly assumed within the code, and cannot be changed
17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	34 local BOSH_HOLD = 1;
17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	35 local BOSH_MAX_REQUESTS = 2;
17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	36
17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	37 -- The number of seconds a BOSH session should remain open with no requests
17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	38 local bosh_max_inactivity = module:get_option_number("bosh_max_inactivity", 60);
17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	39 -- The minimum amount of time between requests with no payload
17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	40 local bosh_max_polling = module:get_option_number("bosh_max_polling", 5);
17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	41 -- The maximum amount of time that the server will hold onto a request before replying
17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	42 -- (the client can set this to a lower value when it connects, if it chooses)
5185 ca30b21946ef mod_bosh: Add bosh_max_wait config option, to limit the amount of time a client can request for the server to hold open requests Matthew Wild <mwild1@gmail.com> parents: 5179 diff changeset	43 local bosh_max_wait = module:get_option_number("bosh_max_wait", 120);
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	44
3070 3238b58fd118 mod_bosh: Add option consider_bosh_secure to treat BOSH sessions as encrypted even if they don't use HTTP (useful for when secure requests are proxied to Prosody over HTTP) Matthew Wild <mwild1@gmail.com> parents: 3043 diff changeset	45 local consider_bosh_secure = module:get_option_boolean("consider_bosh_secure");
4332 8154bc28e520 mod_bosh: Update to use typed variants of module:get_option(), makes it more tolerant to config variations and simplifies the code. Matthew Wild <mwild1@gmail.com> parents: 4327 diff changeset	46 local cross_domain = module:get_option("cross_domain_bosh", false);
2484 cf924f587410 mod_bosh: Support for cross-domain access control using CORS Matthew Wild <mwild1@gmail.com> parents: 2473 diff changeset	47
5667 0bf1cdea43f6 mod_bosh: Reduce a little code. Waqas Hussain <waqas20@gmail.com> parents: 5660 diff changeset	48 if cross_domain == true then cross_domain = "*"; end
5648 f7f667c48d9a mod_bosh: Clean up handling of response headers, set them only in one place Matthew Wild <mwild1@gmail.com> parents: 5647 diff changeset	49 if type(cross_domain) == "table" then cross_domain = table.concat(cross_domain, ", "); end
2484 cf924f587410 mod_bosh: Support for cross-domain access control using CORS Matthew Wild <mwild1@gmail.com> parents: 2473 diff changeset	50
3472 61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	51 local trusted_proxies = module:get_option_set("trusted_proxies", {"127.0.0.1"})._items;
61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	52
61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	53 local function get_ip_from_request(request)
4447 57d7362a9312 mod_bosh: Fixed use of a private HTTP request property. Waqas Hussain <waqas20@gmail.com> parents: 4442 diff changeset	54 local ip = request.conn:ip();
4998 f6c1f98419be mod_bosh: Use new format for headers when checking for proxies to get the originating IP Kim Alvefur <zash@zash.se> parents: 4880 diff changeset	55 local forwarded_for = request.headers.x_forwarded_for;
3472 61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	56 if forwarded_for then
61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	57 forwarded_for = forwarded_for..", "..ip;
61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	58 for forwarded_ip in forwarded_for:gmatch("[^%s,]+") do
61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	59 if not trusted_proxies[forwarded_ip] then
61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	60 ip = forwarded_ip;
61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	61 end
61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	62 end
61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	63 end
61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	64 return ip;
61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	65 end
61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	66
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	67 local t_insert, t_remove, t_concat = table.insert, table.remove, table.concat;
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	68 local os_time = os.time;
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	69
5179 f3662fea95d9 mod_bosh: Share sessions and inactive_sessions tables Matthew Wild <mwild1@gmail.com> parents: 5071 diff changeset	70 -- All sessions, and sessions that have no requests open
f3662fea95d9 mod_bosh: Share sessions and inactive_sessions tables Matthew Wild <mwild1@gmail.com> parents: 5071 diff changeset	71 local sessions, inactive_sessions = module:shared("sessions", "inactive_sessions");
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	72
679 9506bf204b1a Numerous BOSH improvements... handle client disconnects, either explicit or implicit through inactivity; allow specifying BOSH default parameters through config; fix to prevent prematurely closing request connections in some cases, before they were replied to Matthew Wild <mwild1@gmail.com> parents: 660 diff changeset	73 -- Used to respond to idle sessions (those with waiting requests)
5660 df077bc8f019 mod_bosh: Make waiting_requests and dead_sessions shared to preserve across reloads Matthew Wild <mwild1@gmail.com> parents: 5658 diff changeset	74 local waiting_requests = module:shared("waiting_requests");
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	75 function on_destroy_request(request)
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	76 log("debug", "Request destroyed: %s", tostring(request));
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	77 waiting_requests[request] = nil;
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	78 local session = sessions[request.context.sid];
816 c031ead9896d mod_bosh: Possible fix for invalid key to next crash Matthew Wild <mwild1@gmail.com> parents: 772 diff changeset	79 if session then
c031ead9896d mod_bosh: Possible fix for invalid key to next crash Matthew Wild <mwild1@gmail.com> parents: 772 diff changeset	80 local requests = session.requests;
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	81 for i, r in ipairs(requests) do
3039 2fef108d7eb7 mod_bosh: Remove requests from the session table using table.remove(), prevents the possibility of holes in the array. Matthew Wild <mwild1@gmail.com> parents: 2959 diff changeset	82 if r == request then
2fef108d7eb7 mod_bosh: Remove requests from the session table using table.remove(), prevents the possibility of holes in the array. Matthew Wild <mwild1@gmail.com> parents: 2959 diff changeset	83 t_remove(requests, i);
2fef108d7eb7 mod_bosh: Remove requests from the session table using table.remove(), prevents the possibility of holes in the array. Matthew Wild <mwild1@gmail.com> parents: 2959 diff changeset	84 break;
2fef108d7eb7 mod_bosh: Remove requests from the session table using table.remove(), prevents the possibility of holes in the array. Matthew Wild <mwild1@gmail.com> parents: 2959 diff changeset	85 end
816 c031ead9896d mod_bosh: Possible fix for invalid key to next crash Matthew Wild <mwild1@gmail.com> parents: 772 diff changeset	86 end
5776 bd0ff8ae98a8 Remove all trailing whitespace Florian Zeitz <florob@babelmonkeys.de> parents: 5748 diff changeset	87
816 c031ead9896d mod_bosh: Possible fix for invalid key to next crash Matthew Wild <mwild1@gmail.com> parents: 772 diff changeset	88 -- If this session now has no requests open, mark it as inactive
4436 aa79b3767f98 mod_bosh: Store time to destroy session in inactive_sessions, removing dependency on session.bosh_max_inactive in cleanup timer Matthew Wild <mwild1@gmail.com> parents: 4379 diff changeset	89 local max_inactive = session.bosh_max_inactive;
aa79b3767f98 mod_bosh: Store time to destroy session in inactive_sessions, removing dependency on session.bosh_max_inactive in cleanup timer Matthew Wild <mwild1@gmail.com> parents: 4379 diff changeset	90 if max_inactive and #requests == 0 then
aa79b3767f98 mod_bosh: Store time to destroy session in inactive_sessions, removing dependency on session.bosh_max_inactive in cleanup timer Matthew Wild <mwild1@gmail.com> parents: 4379 diff changeset	91 inactive_sessions[session] = os_time() + max_inactive;
aa79b3767f98 mod_bosh: Store time to destroy session in inactive_sessions, removing dependency on session.bosh_max_inactive in cleanup timer Matthew Wild <mwild1@gmail.com> parents: 4379 diff changeset	92 (session.log or log)("debug", "BOSH session marked as inactive (for %ds)", max_inactive);
816 c031ead9896d mod_bosh: Possible fix for invalid key to next crash Matthew Wild <mwild1@gmail.com> parents: 772 diff changeset	93 end
c031ead9896d mod_bosh: Possible fix for invalid key to next crash Matthew Wild <mwild1@gmail.com> parents: 772 diff changeset	94 end
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	95 end
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	96
5648 f7f667c48d9a mod_bosh: Clean up handling of response headers, set them only in one place Matthew Wild <mwild1@gmail.com> parents: 5647 diff changeset	97 local function set_cross_domain_headers(response)
f7f667c48d9a mod_bosh: Clean up handling of response headers, set them only in one place Matthew Wild <mwild1@gmail.com> parents: 5647 diff changeset	98 local headers = response.headers;
f7f667c48d9a mod_bosh: Clean up handling of response headers, set them only in one place Matthew Wild <mwild1@gmail.com> parents: 5647 diff changeset	99 headers.access_control_allow_methods = "GET, POST, OPTIONS";
f7f667c48d9a mod_bosh: Clean up handling of response headers, set them only in one place Matthew Wild <mwild1@gmail.com> parents: 5647 diff changeset	100 headers.access_control_allow_headers = "Content-Type";
f7f667c48d9a mod_bosh: Clean up handling of response headers, set them only in one place Matthew Wild <mwild1@gmail.com> parents: 5647 diff changeset	101 headers.access_control_max_age = "7200";
5667 0bf1cdea43f6 mod_bosh: Reduce a little code. Waqas Hussain <waqas20@gmail.com> parents: 5660 diff changeset	102 headers.access_control_allow_origin = cross_domain;
5648 f7f667c48d9a mod_bosh: Clean up handling of response headers, set them only in one place Matthew Wild <mwild1@gmail.com> parents: 5647 diff changeset	103 return response;
f7f667c48d9a mod_bosh: Clean up handling of response headers, set them only in one place Matthew Wild <mwild1@gmail.com> parents: 5647 diff changeset	104 end
f7f667c48d9a mod_bosh: Clean up handling of response headers, set them only in one place Matthew Wild <mwild1@gmail.com> parents: 5647 diff changeset	105
5652 bfb290c8cd73 mod_bosh: Rename event handler argument to event, not request. Waqas Hussain <waqas20@gmail.com> parents: 5651 diff changeset	106 function handle_OPTIONS(event)
5654 020c5cd6eb28 mod_bosh: Only return CORS headers if the Origin header is received, and CORS is enabled. Waqas Hussain <waqas20@gmail.com> parents: 5653 diff changeset	107 if cross_domain and event.request.headers.origin then
020c5cd6eb28 mod_bosh: Only return CORS headers if the Origin header is received, and CORS is enabled. Waqas Hussain <waqas20@gmail.com> parents: 5653 diff changeset	108 set_cross_domain_headers(event.response);
020c5cd6eb28 mod_bosh: Only return CORS headers if the Origin header is received, and CORS is enabled. Waqas Hussain <waqas20@gmail.com> parents: 5653 diff changeset	109 end
5653 c7d10b1a64b1 mod_bosh: Return empty string from the OPTIONS event handler, don't return the response object itself. Waqas Hussain <waqas20@gmail.com> parents: 5652 diff changeset	110 return "";
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	111 end
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	112
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	113 function handle_POST(event)
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	114 log("debug", "Handling new request %s: %s\n----------", tostring(event.request), tostring(event.request.body));
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	115
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	116 local request, response = event.request, event.response;
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	117 response.on_destroy = on_destroy_request;
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	118 local body = request.body;
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	119
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	120 local context = { request = request, response = response, notopen = true };
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	121 local stream = new_xmpp_stream(context, stream_callbacks);
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	122 response.context = context;
5648 f7f667c48d9a mod_bosh: Clean up handling of response headers, set them only in one place Matthew Wild <mwild1@gmail.com> parents: 5647 diff changeset	123
f7f667c48d9a mod_bosh: Clean up handling of response headers, set them only in one place Matthew Wild <mwild1@gmail.com> parents: 5647 diff changeset	124 local headers = response.headers;
f7f667c48d9a mod_bosh: Clean up handling of response headers, set them only in one place Matthew Wild <mwild1@gmail.com> parents: 5647 diff changeset	125 headers.content_type = "text/xml; charset=utf-8";
f7f667c48d9a mod_bosh: Clean up handling of response headers, set them only in one place Matthew Wild <mwild1@gmail.com> parents: 5647 diff changeset	126
5654 020c5cd6eb28 mod_bosh: Only return CORS headers if the Origin header is received, and CORS is enabled. Waqas Hussain <waqas20@gmail.com> parents: 5653 diff changeset	127 if cross_domain and event.request.headers.origin then
5648 f7f667c48d9a mod_bosh: Clean up handling of response headers, set them only in one place Matthew Wild <mwild1@gmail.com> parents: 5647 diff changeset	128 set_cross_domain_headers(response);
f7f667c48d9a mod_bosh: Clean up handling of response headers, set them only in one place Matthew Wild <mwild1@gmail.com> parents: 5647 diff changeset	129 end
5776 bd0ff8ae98a8 Remove all trailing whitespace Florian Zeitz <florob@babelmonkeys.de> parents: 5748 diff changeset	130
3707 79f62694d36e mod_bosh: Switch to util.xmppstream from xmlhandlers Matthew Wild <mwild1@gmail.com> parents: 3684 diff changeset	131 -- stream:feed() calls the stream_callbacks, so all stanzas in
79f62694d36e mod_bosh: Switch to util.xmppstream from xmlhandlers Matthew Wild <mwild1@gmail.com> parents: 3684 diff changeset	132 -- the body are processed in this next line before it returns.
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	133 -- In particular, the streamopened() stream callback is where
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	134 -- much of the session logic happens, because it's where we first
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	135 -- get to see the 'sid' of this request.
7376 f9a5d9f60561 mod_bosh: Log error returned from stream:feed() Kim Alvefur <zash@zash.se> parents: 7375 diff changeset	136 local ok, err = stream:feed(body);
f9a5d9f60561 mod_bosh: Log error returned from stream:feed() Kim Alvefur <zash@zash.se> parents: 7375 diff changeset	137 if not ok then
f9a5d9f60561 mod_bosh: Log error returned from stream:feed() Kim Alvefur <zash@zash.se> parents: 7375 diff changeset	138 module:log("warn", "Error parsing BOSH payload; %s", err)
7377 6c98e783272a mod_bosh: Return a proper BOSH error response instead of deprecated(?) status code (See #343) Kim Alvefur <zash@zash.se> parents: 7376 diff changeset	139 local close_reply = st.stanza("body", { xmlns = xmlns_bosh, type = "terminate",
6c98e783272a mod_bosh: Return a proper BOSH error response instead of deprecated(?) status code (See #343) Kim Alvefur <zash@zash.se> parents: 7376 diff changeset	140 ["xmlns:stream"] = xmlns_streams, condition = "bad-request" });
6c98e783272a mod_bosh: Return a proper BOSH error response instead of deprecated(?) status code (See #343) Kim Alvefur <zash@zash.se> parents: 7376 diff changeset	141 return tostring(close_reply);
5647 8767b47524c9 mod_bosh: Return errors when appropriate (invalid XML, missing sid) Matthew Wild <mwild1@gmail.com> parents: 5646 diff changeset	142 end
5776 bd0ff8ae98a8 Remove all trailing whitespace Florian Zeitz <florob@babelmonkeys.de> parents: 5748 diff changeset	143
4438 7f51186ed28b mod_bosh: Move stream:features sending until after the current request has been added to session.requests. Ensures correct inactivity logic. Matthew Wild <mwild1@gmail.com> parents: 4437 diff changeset	144 -- Stanzas (if any) in the request have now been processed, and
7f51186ed28b mod_bosh: Move stream:features sending until after the current request has been added to session.requests. Ensures correct inactivity logic. Matthew Wild <mwild1@gmail.com> parents: 4437 diff changeset	145 -- we take care of the high-level BOSH logic here, including
7f51186ed28b mod_bosh: Move stream:features sending until after the current request has been added to session.requests. Ensures correct inactivity logic. Matthew Wild <mwild1@gmail.com> parents: 4437 diff changeset	146 -- giving a response or putting the request "on hold".
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	147 local session = sessions[context.sid];
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	148 if session then
4308 50e1a3dc2b50 mod_bosh: Mark a session as active when a request comes in, even if we don't end up holding that request, fixes BOSH ghosts (thanks smoku) Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	149 -- Session was marked as inactive, since we have
50e1a3dc2b50 mod_bosh: Mark a session as active when a request comes in, even if we don't end up holding that request, fixes BOSH ghosts (thanks smoku) Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	150 -- a request open now, unmark it
50e1a3dc2b50 mod_bosh: Mark a session as active when a request comes in, even if we don't end up holding that request, fixes BOSH ghosts (thanks smoku) Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	151 if inactive_sessions[session] and #session.requests > 0 then
50e1a3dc2b50 mod_bosh: Mark a session as active when a request comes in, even if we don't end up holding that request, fixes BOSH ghosts (thanks smoku) Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	152 inactive_sessions[session] = nil;
50e1a3dc2b50 mod_bosh: Mark a session as active when a request comes in, even if we don't end up holding that request, fixes BOSH ghosts (thanks smoku) Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	153 end
4000 ca91d6e1d802 mod_bosh: Fix for miscalculating inactivity, causing disconnects under a steady stream of traffic Matthew Wild <mwild1@gmail.com> parents: 3725 diff changeset	154
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	155 local r = session.requests;
7653 17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	156 log("debug", "Session %s has %d out of %d requests open", context.sid, #r, BOSH_HOLD);
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	157 log("debug", "and there are %d things in the send_buffer:", #session.send_buffer);
7653 17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	158 if #r > BOSH_HOLD then
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	159 -- We are holding too many requests, send what's in the buffer,
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	160 log("debug", "We are holding too many requests, so...");
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	161 if #session.send_buffer > 0 then
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	162 log("debug", "...sending what is in the buffer")
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	163 session.send(t_concat(session.send_buffer));
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	164 session.send_buffer = {};
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	165 else
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	166 -- or an empty response
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	167 log("debug", "...sending an empty response");
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	168 session.send("");
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	169 end
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	170 elseif #session.send_buffer > 0 then
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	171 log("debug", "Session has data in the send buffer, will send now..");
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	172 local resp = t_concat(session.send_buffer);
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	173 session.send_buffer = {};
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	174 session.send(resp);
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	175 end
5776 bd0ff8ae98a8 Remove all trailing whitespace Florian Zeitz <florob@babelmonkeys.de> parents: 5748 diff changeset	176
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	177 if not response.finished then
3042 b1961f6c9853 mod_bosh: Always give requests a destroy handler, so that the management of each session's request array and the inactive_sessions logic can happen in one place. Simplifies everything and concludes this series of BOSH fixes. Matthew Wild <mwild1@gmail.com> parents: 3041 diff changeset	178 -- We're keeping this request open, to respond later
b1961f6c9853 mod_bosh: Always give requests a destroy handler, so that the management of each session's request array and the inactive_sessions logic can happen in one place. Simplifies everything and concludes this series of BOSH fixes. Matthew Wild <mwild1@gmail.com> parents: 3041 diff changeset	179 log("debug", "Have nothing to say, so leaving request unanswered for now");
b1961f6c9853 mod_bosh: Always give requests a destroy handler, so that the management of each session's request array and the inactive_sessions logic can happen in one place. Simplifies everything and concludes this series of BOSH fixes. Matthew Wild <mwild1@gmail.com> parents: 3041 diff changeset	180 if session.bosh_wait then
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	181 waiting_requests[response] = os_time() + session.bosh_wait;
3042 b1961f6c9853 mod_bosh: Always give requests a destroy handler, so that the management of each session's request array and the inactive_sessions logic can happen in one place. Simplifies everything and concludes this series of BOSH fixes. Matthew Wild <mwild1@gmail.com> parents: 3041 diff changeset	182 end
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	183 end
5776 bd0ff8ae98a8 Remove all trailing whitespace Florian Zeitz <florob@babelmonkeys.de> parents: 5748 diff changeset	184
4223 9fb6e8ec15ed mod_bosh: Fix terminate logic - process any stanzas in a terminating request, and add type='terminate' to any responses generated by those stanzas. Finally, close all remaining open requests with type='terminate' and close the session. Fixes #211 (thanks Maranda + waqas). Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	185 if session.bosh_terminate then
9fb6e8ec15ed mod_bosh: Fix terminate logic - process any stanzas in a terminating request, and add type='terminate' to any responses generated by those stanzas. Finally, close all remaining open requests with type='terminate' and close the session. Fixes #211 (thanks Maranda + waqas). Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	186 session.log("debug", "Closing session with %d requests open", #session.requests);
9fb6e8ec15ed mod_bosh: Fix terminate logic - process any stanzas in a terminating request, and add type='terminate' to any responses generated by those stanzas. Finally, close all remaining open requests with type='terminate' and close the session. Fixes #211 (thanks Maranda + waqas). Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	187 session:close();
9fb6e8ec15ed mod_bosh: Fix terminate logic - process any stanzas in a terminating request, and add type='terminate' to any responses generated by those stanzas. Finally, close all remaining open requests with type='terminate' and close the session. Fixes #211 (thanks Maranda + waqas). Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	188 return nil;
9fb6e8ec15ed mod_bosh: Fix terminate logic - process any stanzas in a terminating request, and add type='terminate' to any responses generated by those stanzas. Finally, close all remaining open requests with type='terminate' and close the session. Fixes #211 (thanks Maranda + waqas). Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	189 else
4738 e95458712782 mod_bosh: Remove unused import of net.httpserver Matthew Wild <mwild1@gmail.com> parents: 4725 diff changeset	190 return true; -- Inform http server we shall reply later
4223 9fb6e8ec15ed mod_bosh: Fix terminate logic - process any stanzas in a terminating request, and add type='terminate' to any responses generated by those stanzas. Finally, close all remaining open requests with type='terminate' and close the session. Fixes #211 (thanks Maranda + waqas). Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	191 end
7375 6ae3cf899b25 mod_bosh: Return if a response has been sent already (See #343) Kim Alvefur <zash@zash.se> parents: 7374 diff changeset	192 elseif response.finished then
6ae3cf899b25 mod_bosh: Return if a response has been sent already (See #343) Kim Alvefur <zash@zash.se> parents: 7374 diff changeset	193 return; -- A response has been sent already
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	194 end
5647 8767b47524c9 mod_bosh: Return errors when appropriate (invalid XML, missing sid) Matthew Wild <mwild1@gmail.com> parents: 5646 diff changeset	195 module:log("warn", "Unable to associate request with a session (incomplete request?)");
7377 6c98e783272a mod_bosh: Return a proper BOSH error response instead of deprecated(?) status code (See #343) Kim Alvefur <zash@zash.se> parents: 7376 diff changeset	196 local close_reply = st.stanza("body", { xmlns = xmlns_bosh, type = "terminate",
6c98e783272a mod_bosh: Return a proper BOSH error response instead of deprecated(?) status code (See #343) Kim Alvefur <zash@zash.se> parents: 7376 diff changeset	197 ["xmlns:stream"] = xmlns_streams, condition = "item-not-found" });
6c98e783272a mod_bosh: Return a proper BOSH error response instead of deprecated(?) status code (See #343) Kim Alvefur <zash@zash.se> parents: 7376 diff changeset	198 return tostring(close_reply) .. "\n";
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	199 end
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	200
684 b7d85c6a0002 Implement session:close() for BOSH, and add checking for attempts to connect to hosts we don't serve Matthew Wild <mwild1@gmail.com> parents: 683 diff changeset	201
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	202 local function bosh_reset_stream(session) session.notopen = true; end
684 b7d85c6a0002 Implement session:close() for BOSH, and add checking for attempts to connect to hosts we don't serve Matthew Wild <mwild1@gmail.com> parents: 683 diff changeset	203
3448 0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	204 local stream_xmlns_attr = { xmlns = "urn:ietf:params:xml:ns:xmpp-streams" };
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	205
684 b7d85c6a0002 Implement session:close() for BOSH, and add checking for attempts to connect to hosts we don't serve Matthew Wild <mwild1@gmail.com> parents: 683 diff changeset	206 local function bosh_close_stream(session, reason)
b7d85c6a0002 Implement session:close() for BOSH, and add checking for attempts to connect to hosts we don't serve Matthew Wild <mwild1@gmail.com> parents: 683 diff changeset	207 (session.log or log)("info", "BOSH client disconnected");
5776 bd0ff8ae98a8 Remove all trailing whitespace Florian Zeitz <florob@babelmonkeys.de> parents: 5748 diff changeset	208
3448 0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	209 local close_reply = st.stanza("body", { xmlns = xmlns_bosh, type = "terminate",
4379 e4d88f4a780c mod_bosh: s/xmlns:streams/xmlns:stream/ - fixes #265 (thanks Tim) Matthew Wild <mwild1@gmail.com> parents: 4332 diff changeset	210 ["xmlns:stream"] = xmlns_streams });
5776 bd0ff8ae98a8 Remove all trailing whitespace Florian Zeitz <florob@babelmonkeys.de> parents: 5748 diff changeset	211
3448 0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	212
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	213 if reason then
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	214 close_reply.attr.condition = "remote-stream-error";
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	215 if type(reason) == "string" then -- assume stream error
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	216 close_reply:tag("stream:error")
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	217 :tag(reason, {xmlns = xmlns_xmpp_streams});
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	218 elseif type(reason) == "table" then
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	219 if reason.condition then
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	220 close_reply:tag("stream:error")
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	221 :tag(reason.condition, stream_xmlns_attr):up();
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	222 if reason.text then
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	223 close_reply:tag("text", stream_xmlns_attr):text(reason.text):up();
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	224 end
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	225 if reason.extra then
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	226 close_reply:add_child(reason.extra);
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	227 end
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	228 elseif reason.name then -- a stanza
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	229 close_reply = reason;
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	230 end
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	231 end
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	232 log("info", "Disconnecting client, <stream:error> is: %s", tostring(close_reply));
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	233 end
0ca7c3864431 mod_bosh: Much improve session:close() for BOSH sessions, so it now matches in usage normal session:close() Matthew Wild <mwild1@gmail.com> parents: 3447 diff changeset	234
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	235 local response_body = tostring(close_reply);
684 b7d85c6a0002 Implement session:close() for BOSH, and add checking for attempts to connect to hosts we don't serve Matthew Wild <mwild1@gmail.com> parents: 683 diff changeset	236 for _, held_request in ipairs(session.requests) do
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	237 held_request:send(response_body);
684 b7d85c6a0002 Implement session:close() for BOSH, and add checking for attempts to connect to hosts we don't serve Matthew Wild <mwild1@gmail.com> parents: 683 diff changeset	238 end
5634 7298c9bbb30f mod_bosh: Some very minor whitespace/layout fixes Matthew Wild <mwild1@gmail.com> parents: 5188 diff changeset	239 sessions[session.sid] = nil;
4437 916681a9a7be mod_bosh: Remove a session from inactive_sessions before destroying it Matthew Wild <mwild1@gmail.com> parents: 4436 diff changeset	240 inactive_sessions[session] = nil;
684 b7d85c6a0002 Implement session:close() for BOSH, and add checking for attempts to connect to hosts we don't serve Matthew Wild <mwild1@gmail.com> parents: 683 diff changeset	241 sm_destroy_session(session);
b7d85c6a0002 Implement session:close() for BOSH, and add checking for attempts to connect to hosts we don't serve Matthew Wild <mwild1@gmail.com> parents: 683 diff changeset	242 end
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	243
4438 7f51186ed28b mod_bosh: Move stream:features sending until after the current request has been added to session.requests. Ensures correct inactivity logic. Matthew Wild <mwild1@gmail.com> parents: 4437 diff changeset	244 -- Handle the <body> tag in the request payload.
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	245 function stream_callbacks.streamopened(context, attr)
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	246 local request, response = context.request, context.response;
4327 98ae0d0b4d07 mod_bosh: Fix logging when no sid present, fix a missing semi-colon, avoid an extra useless table lookup (thanks Thomas) Matthew Wild <mwild1@gmail.com> parents: 4316 diff changeset	247 local sid = attr.sid;
98ae0d0b4d07 mod_bosh: Fix logging when no sid present, fix a missing semi-colon, avoid an extra useless table lookup (thanks Thomas) Matthew Wild <mwild1@gmail.com> parents: 4316 diff changeset	248 log("debug", "BOSH body open (sid: %s)", sid or "<none>");
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	249 if not sid then
679 9506bf204b1a Numerous BOSH improvements... handle client disconnects, either explicit or implicit through inactivity; allow specifying BOSH default parameters through config; fix to prevent prematurely closing request connections in some cases, before they were replied to Matthew Wild <mwild1@gmail.com> parents: 660 diff changeset	250 -- New session request
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	251 context.notopen = nil; -- Signals that we accept this opening tag
5776 bd0ff8ae98a8 Remove all trailing whitespace Florian Zeitz <florob@babelmonkeys.de> parents: 5748 diff changeset	252
7378 d15cfe8627ad mod_bosh: Validate 'to' host (see #343) Kim Alvefur <zash@zash.se> parents: 7377 diff changeset	253 local to_host = nameprep(attr.to);
7379 250855633092 mod_bosh: Validate that 'sid' and 'wait' have sane values (fixes #475, also see #343) Kim Alvefur <zash@zash.se> parents: 7378 diff changeset	254 local rid = tonumber(attr.rid);
250855633092 mod_bosh: Validate that 'sid' and 'wait' have sane values (fixes #475, also see #343) Kim Alvefur <zash@zash.se> parents: 7378 diff changeset	255 local wait = tonumber(attr.wait);
7378 d15cfe8627ad mod_bosh: Validate 'to' host (see #343) Kim Alvefur <zash@zash.se> parents: 7377 diff changeset	256 if not to_host then
d15cfe8627ad mod_bosh: Validate 'to' host (see #343) Kim Alvefur <zash@zash.se> parents: 7377 diff changeset	257 log("debug", "BOSH client tried to connect to invalid host: %s", tostring(attr.to));
d15cfe8627ad mod_bosh: Validate 'to' host (see #343) Kim Alvefur <zash@zash.se> parents: 7377 diff changeset	258 local close_reply = st.stanza("body", { xmlns = xmlns_bosh, type = "terminate",
d15cfe8627ad mod_bosh: Validate 'to' host (see #343) Kim Alvefur <zash@zash.se> parents: 7377 diff changeset	259 ["xmlns:stream"] = xmlns_streams, condition = "improper-addressing" });
d15cfe8627ad mod_bosh: Validate 'to' host (see #343) Kim Alvefur <zash@zash.se> parents: 7377 diff changeset	260 response:send(tostring(close_reply));
d15cfe8627ad mod_bosh: Validate 'to' host (see #343) Kim Alvefur <zash@zash.se> parents: 7377 diff changeset	261 return;
d15cfe8627ad mod_bosh: Validate 'to' host (see #343) Kim Alvefur <zash@zash.se> parents: 7377 diff changeset	262 elseif not hosts[to_host] then
684 b7d85c6a0002 Implement session:close() for BOSH, and add checking for attempts to connect to hosts we don't serve Matthew Wild <mwild1@gmail.com> parents: 683 diff changeset	263 -- Unknown host
1048 45fc590539cd mod_bosh: Add log message for clients connecting to unknown host Matthew Wild <mwild1@gmail.com> parents: 1047 diff changeset	264 log("debug", "BOSH client tried to connect to unknown host: %s", tostring(attr.to));
3492 6d782b1fcc8a mod_bosh: Fix traceback when initiating a BOSH session to an unknown host Matthew Wild <mwild1@gmail.com> parents: 3472 diff changeset	265 local close_reply = st.stanza("body", { xmlns = xmlns_bosh, type = "terminate",
4379 e4d88f4a780c mod_bosh: s/xmlns:streams/xmlns:stream/ - fixes #265 (thanks Tim) Matthew Wild <mwild1@gmail.com> parents: 4332 diff changeset	266 ["xmlns:stream"] = xmlns_streams, condition = "host-unknown" });
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	267 response:send(tostring(close_reply));
684 b7d85c6a0002 Implement session:close() for BOSH, and add checking for attempts to connect to hosts we don't serve Matthew Wild <mwild1@gmail.com> parents: 683 diff changeset	268 return;
b7d85c6a0002 Implement session:close() for BOSH, and add checking for attempts to connect to hosts we don't serve Matthew Wild <mwild1@gmail.com> parents: 683 diff changeset	269 end
7381 a05bf94646ba mod_bosh: Reject fractional 'wait' (See #343) Kim Alvefur <zash@zash.se> parents: 7380 diff changeset	270 if not rid or (not wait and attr.wait or wait < 0 or wait % 1 ~= 0) then
7379 250855633092 mod_bosh: Validate that 'sid' and 'wait' have sane values (fixes #475, also see #343) Kim Alvefur <zash@zash.se> parents: 7378 diff changeset	271 log("debug", "BOSH client sent invalid rid or wait attributes: rid=%s, wait=%s", tostring(attr.rid), tostring(attr.wait));
250855633092 mod_bosh: Validate that 'sid' and 'wait' have sane values (fixes #475, also see #343) Kim Alvefur <zash@zash.se> parents: 7378 diff changeset	272 local close_reply = st.stanza("body", { xmlns = xmlns_bosh, type = "terminate",
250855633092 mod_bosh: Validate that 'sid' and 'wait' have sane values (fixes #475, also see #343) Kim Alvefur <zash@zash.se> parents: 7378 diff changeset	273 ["xmlns:stream"] = xmlns_streams, condition = "bad-request" });
250855633092 mod_bosh: Validate that 'sid' and 'wait' have sane values (fixes #475, also see #343) Kim Alvefur <zash@zash.se> parents: 7378 diff changeset	274 response:send(tostring(close_reply));
250855633092 mod_bosh: Validate that 'sid' and 'wait' have sane values (fixes #475, also see #343) Kim Alvefur <zash@zash.se> parents: 7378 diff changeset	275 return;
250855633092 mod_bosh: Validate that 'sid' and 'wait' have sane values (fixes #475, also see #343) Kim Alvefur <zash@zash.se> parents: 7378 diff changeset	276 end
250855633092 mod_bosh: Validate that 'sid' and 'wait' have sane values (fixes #475, also see #343) Kim Alvefur <zash@zash.se> parents: 7378 diff changeset	277
250855633092 mod_bosh: Validate that 'sid' and 'wait' have sane values (fixes #475, also see #343) Kim Alvefur <zash@zash.se> parents: 7378 diff changeset	278 rid = rid - 1;
250855633092 mod_bosh: Validate that 'sid' and 'wait' have sane values (fixes #475, also see #343) Kim Alvefur <zash@zash.se> parents: 7378 diff changeset	279 wait = math_min(wait, bosh_max_wait);
5776 bd0ff8ae98a8 Remove all trailing whitespace Florian Zeitz <florob@babelmonkeys.de> parents: 5748 diff changeset	280
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	281 -- New session
763 8e77a39826c2 mod_bosh: No need to tostring() uuids now Matthew Wild <mwild1@gmail.com> parents: 725 diff changeset	282 sid = new_uuid();
3071 39a870ae75d9 mod_bosh: Re-layout session object creation to make lines shorter Matthew Wild <mwild1@gmail.com> parents: 3070 diff changeset	283 local session = {
7387 addd041342bd mod_bosh: Don't decrement rid twice (thanks av6) Kim Alvefur <zash@zash.se> parents: 7381 diff changeset	284 type = "c2s_unauthed", conn = {}, sid = sid, rid = rid, host = attr.to,
7379 250855633092 mod_bosh: Validate that 'sid' and 'wait' have sane values (fixes #475, also see #343) Kim Alvefur <zash@zash.se> parents: 7378 diff changeset	285 bosh_version = attr.ver, bosh_wait = wait, streamid = sid,
7653 17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	286 bosh_max_inactive = bosh_max_inactivity,
3071 39a870ae75d9 mod_bosh: Re-layout session object creation to make lines shorter Matthew Wild <mwild1@gmail.com> parents: 3070 diff changeset	287 requests = { }, send_buffer = {}, reset_stream = bosh_reset_stream,
5071 0382f456ac82 mod_bosh: Remove redundant code (send stream features in only one place) (thanks Zash) Matthew Wild <mwild1@gmail.com> parents: 5070 diff changeset	288 close = bosh_close_stream, dispatch_stanza = core_process_stanza, notopen = true,
3472 61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	289 log = logger.init("bosh"..sid), secure = consider_bosh_secure or request.secure,
61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	290 ip = get_ip_from_request(request);
3071 39a870ae75d9 mod_bosh: Re-layout session object creation to make lines shorter Matthew Wild <mwild1@gmail.com> parents: 3070 diff changeset	291 };
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	292 sessions[sid] = session;
5776 bd0ff8ae98a8 Remove all trailing whitespace Florian Zeitz <florob@babelmonkeys.de> parents: 5748 diff changeset	293
5187 d71f731e8fe4 mod_bosh: Add support for stanza filters to BOSH sessions (needed by some plugins) Matthew Wild <mwild1@gmail.com> parents: 5185 diff changeset	294 local filter = initialize_filters(session);
5776 bd0ff8ae98a8 Remove all trailing whitespace Florian Zeitz <florob@babelmonkeys.de> parents: 5748 diff changeset	295
3472 61cf3e7d7f07 mod_bosh: Support for reading the client's real IP through HTTP proxies from X-Forwarded-For Matthew Wild <mwild1@gmail.com> parents: 3460 diff changeset	296 session.log("debug", "BOSH session created for request from %s", session.ip);
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	297 log("info", "New BOSH session, assigned it sid '%s'", sid);
5046 16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	298
7047 9ca2b720ad43 mod_bosh: Fire event when BOSH session is created Matthew Wild <mwild1@gmail.com> parents: 6528 diff changeset	299 hosts[session.host].events.fire_event("bosh-session", { session = session, request = request });
9ca2b720ad43 mod_bosh: Fire event when BOSH session is created Matthew Wild <mwild1@gmail.com> parents: 6528 diff changeset	300
5046 16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	301 -- Send creation response
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	302 local creating_session = true;
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	303
4769 c91bb217bf79 mod_bosh: Remove unused send_buffer variable Matthew Wild <mwild1@gmail.com> parents: 4768 diff changeset	304 local r = session.requests;
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	305 function session.send(s)
3322 c4e107e7c883 mod_bosh: Add jabber:client namespace to stanzas with no namespace Matthew Wild <mwild1@gmail.com> parents: 3071 diff changeset	306 -- We need to ensure that outgoing stanzas have the jabber:client xmlns
c4e107e7c883 mod_bosh: Add jabber:client namespace to stanzas with no namespace Matthew Wild <mwild1@gmail.com> parents: 3071 diff changeset	307 if s.attr and not s.attr.xmlns then
c4e107e7c883 mod_bosh: Add jabber:client namespace to stanzas with no namespace Matthew Wild <mwild1@gmail.com> parents: 3071 diff changeset	308 s = st.clone(s);
c4e107e7c883 mod_bosh: Add jabber:client namespace to stanzas with no namespace Matthew Wild <mwild1@gmail.com> parents: 3071 diff changeset	309 s.attr.xmlns = "jabber:client";
c4e107e7c883 mod_bosh: Add jabber:client namespace to stanzas with no namespace Matthew Wild <mwild1@gmail.com> parents: 3071 diff changeset	310 end
5187 d71f731e8fe4 mod_bosh: Add support for stanza filters to BOSH sessions (needed by some plugins) Matthew Wild <mwild1@gmail.com> parents: 5185 diff changeset	311 s = filter("stanzas/out", s);
2099 73e083d01449 mod_bosh: Don't log response XML Matthew Wild <mwild1@gmail.com> parents: 2084 diff changeset	312 --log("debug", "Sending BOSH data: %s", tostring(s));
7326 d11701e86702 mod_bosh: Skip sending stanzas removed out by filters (fixes #657) Kim Alvefur <zash@zash.se> parents: 7283 diff changeset	313 if not s then return true end
5046 16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	314 t_insert(session.send_buffer, tostring(s));
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	315
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	316 local oldest_request = r[1];
5046 16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	317 if oldest_request and not session.bosh_processing then
2099 73e083d01449 mod_bosh: Don't log response XML Matthew Wild <mwild1@gmail.com> parents: 2084 diff changeset	318 log("debug", "We have an open request, so sending on that");
5046 16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	319 local body_attr = { xmlns = "http://jabber.org/protocol/httpbind",
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	320 ["xmlns:stream"] = "http://etherx.jabber.org/streams";
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	321 type = session.bosh_terminate and "terminate" or nil;
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	322 sid = sid;
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	323 };
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	324 if creating_session then
5644 f9cfe6f5d60f mod_bosh: Reset creating_session to prevent putting unnecessary attributes into every BOSH response Matthew Wild <mwild1@gmail.com> parents: 5639 diff changeset	325 creating_session = nil;
7653 17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	326 body_attr.requests = tostring(BOSH_MAX_REQUESTS);
17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	327 body_attr.hold = tostring(BOSH_HOLD);
17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	328 body_attr.inactivity = tostring(bosh_max_inactivity);
17e42f793341 mod_bosh: Make 'hold' and 'requests' fixed to '1' and '2' respectively, as this is what all implementations realistically use Matthew Wild <mwild1@gmail.com> parents: 7652 diff changeset	329 body_attr.polling = tostring(bosh_max_polling);
5185 ca30b21946ef mod_bosh: Add bosh_max_wait config option, to limit the amount of time a client can request for the server to hold open requests Matthew Wild <mwild1@gmail.com> parents: 5179 diff changeset	330 body_attr.wait = tostring(session.bosh_wait);
5046 16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	331 body_attr.authid = sid;
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	332 body_attr.secure = "true";
5670 9218a0e81a41 mod_bosh: Fix global write Matthew Wild <mwild1@gmail.com> parents: 5650 diff changeset	333 body_attr.ver = '1.6';
9218a0e81a41 mod_bosh: Fix global write Matthew Wild <mwild1@gmail.com> parents: 5650 diff changeset	334 body_attr.from = session.host;
5046 16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	335 body_attr["xmlns:xmpp"] = "urn:xmpp:xbosh";
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	336 body_attr["xmpp:version"] = "1.0";
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	337 end
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	338 oldest_request:send(st.stanza("body", body_attr):top_tag()..t_concat(session.send_buffer).."</body>");
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	339 session.send_buffer = {};
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	340 end
4102 9df4e61c260b mod_bosh: Return true from send() Matthew Wild <mwild1@gmail.com> parents: 4000 diff changeset	341 return true;
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	342 end
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	343 request.sid = sid;
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	344 end
5776 bd0ff8ae98a8 Remove all trailing whitespace Florian Zeitz <florob@babelmonkeys.de> parents: 5748 diff changeset	345
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	346 local session = sessions[sid];
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	347 if not session then
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	348 -- Unknown sid
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	349 log("info", "Client tried to use sid '%s' which we don't know about", sid);
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	350 response:send(tostring(st.stanza("body", { xmlns = xmlns_bosh, type = "terminate", condition = "item-not-found" })));
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	351 context.notopen = nil;
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	352 return;
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	353 end
5776 bd0ff8ae98a8 Remove all trailing whitespace Florian Zeitz <florob@babelmonkeys.de> parents: 5748 diff changeset	354
1663 b30c4d0bbe84 mod_bosh: Basic handling of rids (more to come) Matthew Wild <mwild1@gmail.com> parents: 1662 diff changeset	355 if session.rid then
b30c4d0bbe84 mod_bosh: Basic handling of rids (more to come) Matthew Wild <mwild1@gmail.com> parents: 1662 diff changeset	356 local rid = tonumber(attr.rid);
1664 6587b6c2678e mod_bosh: Calculate rid difference just once Matthew Wild <mwild1@gmail.com> parents: 1663 diff changeset	357 local diff = rid - session.rid;
7651 55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	358 -- Diff should be 1 for a healthy request
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	359 if diff ~= 1 then
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	360 context.sid = sid;
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	361 context.notopen = nil;
7651 55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	362 if diff == 2 then
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	363 -- Hold request, but don't process it (ouch!)
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	364 session.log("debug", "rid skipped: %d, deferring this request", rid-1)
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	365 context.defer = true;
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	366 session.bosh_deferred = { context = context, sid = sid, rid = rid, terminate = attr.type == "terminate" };
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	367 return;
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	368 end
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	369 context.ignore = true;
7651 55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	370 if diff == 0 then
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	371 -- Re-send previous response, ignore stanzas in this request
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	372 session.log("debug", "rid repeated, ignoring: %s (diff %d)", session.rid, diff);
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	373 response:send(session.bosh_last_response);
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	374 return;
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	375 end
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	376 -- Session broken, destroy it
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	377 session.log("debug", "rid out of range: %d (diff %d)", rid, diff);
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	378 response:send(tostring(st.stanza("body", { xmlns = xmlns_bosh, type = "terminate", condition = "item-not-found" })));
1663 b30c4d0bbe84 mod_bosh: Basic handling of rids (more to come) Matthew Wild <mwild1@gmail.com> parents: 1662 diff changeset	379 return;
b30c4d0bbe84 mod_bosh: Basic handling of rids (more to come) Matthew Wild <mwild1@gmail.com> parents: 1662 diff changeset	380 end
b30c4d0bbe84 mod_bosh: Basic handling of rids (more to come) Matthew Wild <mwild1@gmail.com> parents: 1662 diff changeset	381 session.rid = rid;
b30c4d0bbe84 mod_bosh: Basic handling of rids (more to come) Matthew Wild <mwild1@gmail.com> parents: 1662 diff changeset	382 end
5776 bd0ff8ae98a8 Remove all trailing whitespace Florian Zeitz <florob@babelmonkeys.de> parents: 5748 diff changeset	383
4223 9fb6e8ec15ed mod_bosh: Fix terminate logic - process any stanzas in a terminating request, and add type='terminate' to any responses generated by those stanzas. Finally, close all remaining open requests with type='terminate' and close the session. Fixes #211 (thanks Maranda + waqas). Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	384 if attr.type == "terminate" then
9fb6e8ec15ed mod_bosh: Fix terminate logic - process any stanzas in a terminating request, and add type='terminate' to any responses generated by those stanzas. Finally, close all remaining open requests with type='terminate' and close the session. Fixes #211 (thanks Maranda + waqas). Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	385 -- Client wants to end this session, which we'll do
9fb6e8ec15ed mod_bosh: Fix terminate logic - process any stanzas in a terminating request, and add type='terminate' to any responses generated by those stanzas. Finally, close all remaining open requests with type='terminate' and close the session. Fixes #211 (thanks Maranda + waqas). Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	386 -- after processing any stanzas in this request
9fb6e8ec15ed mod_bosh: Fix terminate logic - process any stanzas in a terminating request, and add type='terminate' to any responses generated by those stanzas. Finally, close all remaining open requests with type='terminate' and close the session. Fixes #211 (thanks Maranda + waqas). Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	387 session.bosh_terminate = true;
9fb6e8ec15ed mod_bosh: Fix terminate logic - process any stanzas in a terminating request, and add type='terminate' to any responses generated by those stanzas. Finally, close all remaining open requests with type='terminate' and close the session. Fixes #211 (thanks Maranda + waqas). Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	388 end
9fb6e8ec15ed mod_bosh: Fix terminate logic - process any stanzas in a terminating request, and add type='terminate' to any responses generated by those stanzas. Finally, close all remaining open requests with type='terminate' and close the session. Fixes #211 (thanks Maranda + waqas). Matthew Wild <mwild1@gmail.com> parents: 4102 diff changeset	389
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	390 context.notopen = nil; -- Signals that we accept this opening tag
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	391 t_insert(session.requests, response);
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	392 context.sid = sid;
5046 16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	393 session.bosh_processing = true; -- Used to suppress replies until processing of this request is done
4438 7f51186ed28b mod_bosh: Move stream:features sending until after the current request has been added to session.requests. Ensures correct inactivity logic. Matthew Wild <mwild1@gmail.com> parents: 4437 diff changeset	394
7f51186ed28b mod_bosh: Move stream:features sending until after the current request has been added to session.requests. Ensures correct inactivity logic. Matthew Wild <mwild1@gmail.com> parents: 4437 diff changeset	395 if session.notopen then
7f51186ed28b mod_bosh: Move stream:features sending until after the current request has been added to session.requests. Ensures correct inactivity logic. Matthew Wild <mwild1@gmail.com> parents: 4437 diff changeset	396 local features = st.stanza("stream:features");
7f51186ed28b mod_bosh: Move stream:features sending until after the current request has been added to session.requests. Ensures correct inactivity logic. Matthew Wild <mwild1@gmail.com> parents: 4437 diff changeset	397 hosts[session.host].events.fire_event("stream-features", { origin = session, features = features });
5658 97c1c1bdd7bc mod_bosh: Don't tostring() stream:features when passing to session.send(). Waqas Hussain <waqas20@gmail.com> parents: 5654 diff changeset	398 session.send(features);
4438 7f51186ed28b mod_bosh: Move stream:features sending until after the current request has been added to session.requests. Ensures correct inactivity logic. Matthew Wild <mwild1@gmail.com> parents: 4437 diff changeset	399 session.notopen = nil;
7f51186ed28b mod_bosh: Move stream:features sending until after the current request has been added to session.requests. Ensures correct inactivity logic. Matthew Wild <mwild1@gmail.com> parents: 4437 diff changeset	400 end
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	401 end
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	402
5727 372ecf3630cf mod_bosh: pcall() core_process_stanza per stanza, to bring in line with other listeners. This ensures that stanzas following a traceback-causing stanza in a request will still be processed (as would happen on normal c2s). Matthew Wild <mwild1@gmail.com> parents: 5726 diff changeset	403 local function handleerr(err) log("error", "Traceback[bosh]: %s", traceback(tostring(err), 2)); end
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	404 function stream_callbacks.handlestanza(context, stanza)
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	405 if context.ignore then return; end
725 96110075288b Replacing pretty_print() with top_tag() for logging Matthew Wild <mwild1@gmail.com> parents: 701 diff changeset	406 log("debug", "BOSH stanza received: %s\n", stanza:top_tag());
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	407 local session = sessions[context.sid];
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	408 if session then
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	409 if stanza.attr.xmlns == xmlns_bosh then
2959 62a3f824292a mod_bosh: Default stanza namespace should be jabber:client (fixes BOSH to work with recent namespace fix) Matthew Wild <mwild1@gmail.com> parents: 2923 diff changeset	410 stanza.attr.xmlns = nil;
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	411 end
7651 55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	412 if context.defer and session.bosh_deferred then
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	413 log("debug", "Deferring this stanza");
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	414 t_insert(session.bosh_deferred, stanza);
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	415 else
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	416 stanza = session.filter("stanzas/in", stanza);
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	417 if stanza then
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	418 return xpcall(function () return core_process_stanza(session, stanza) end, handleerr);
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	419 end
7283 32754b15b28a Backed out BOSH use of util.async (changeset f0687c313cf1) Kim Alvefur <zash@zash.se> parents: 7047 diff changeset	420 end
7652 7cc3d6c764ce mod_bosh: Log when a stanza isn't handled because we can't find a session for it Matthew Wild <mwild1@gmail.com> parents: 7651 diff changeset	421 else
7cc3d6c764ce mod_bosh: Log when a stanza isn't handled because we can't find a session for it Matthew Wild <mwild1@gmail.com> parents: 7651 diff changeset	422 log("debug", "No session for this stanza! (sid: %s)", context.sid or "none!");
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	423 end
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	424 end
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	425
5635 84d3d7b69f9a mod_bosh: rename variable for clarity Matthew Wild <mwild1@gmail.com> parents: 5634 diff changeset	426 function stream_callbacks.streamclosed(context)
84d3d7b69f9a mod_bosh: rename variable for clarity Matthew Wild <mwild1@gmail.com> parents: 5634 diff changeset	427 local session = sessions[context.sid];
5046 16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	428 if session then
7651 55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	429 if not context.defer and session.bosh_deferred then
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	430 -- Handle deferred stanzas now
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	431 local deferred_stanzas = session.bosh_deferred;
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	432 local context = deferred_stanzas.context;
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	433 session.bosh_deferred = nil;
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	434 log("debug", "Handling deferred stanzas from rid %d", deferred_stanzas.rid);
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	435 session.rid = deferred_stanzas.rid;
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	436 t_insert(session.requests, context.response);
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	437 for _, stanza in ipairs(deferred_stanzas) do
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	438 stream_callbacks.handlestanza(context, stanza);
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	439 end
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	440 if deferred_stanzas.terminate then
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	441 session.bosh_terminate = true;
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	442 end
55f11a6806bc mod_bosh: Correctly handle requests arriving out of order (thanks Jitsi folk!) Matthew Wild <mwild1@gmail.com> parents: 7387 diff changeset	443 end
5046 16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	444 session.bosh_processing = false;
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	445 if #session.send_buffer > 0 then
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	446 session.send("");
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	447 end
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	448 end
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	449 end
16c7b510694b mod_bosh: Correctly handle data included in the session initiation request, and cork session while a request is being processed, preventing replying to requests when there may be more data to come, reducing round-trips. Matthew Wild <mwild1@gmail.com> parents: 5031 diff changeset	450
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	451 function stream_callbacks.error(context, error)
3447 cc2dc55e66f9 mod_bosh: Add error callback for xmlhandlers, to handle the case of invalid or unusable XML in the request payload Matthew Wild <mwild1@gmail.com> parents: 3439 diff changeset	452 log("debug", "Error parsing BOSH request payload; %s", error);
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	453 if not context.sid then
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	454 local response = context.response;
7380 d24d88feed76 mod_bosh: Return a proper BOSH error response from XML parse error callback (see #343) Kim Alvefur <zash@zash.se> parents: 7379 diff changeset	455 local close_reply = st.stanza("body", { xmlns = xmlns_bosh, type = "terminate",
d24d88feed76 mod_bosh: Return a proper BOSH error response from XML parse error callback (see #343) Kim Alvefur <zash@zash.se> parents: 7379 diff changeset	456 ["xmlns:stream"] = xmlns_streams, condition = "bad-request" });
d24d88feed76 mod_bosh: Return a proper BOSH error response from XML parse error callback (see #343) Kim Alvefur <zash@zash.se> parents: 7379 diff changeset	457 response:send(tostring(close_reply));
3447 cc2dc55e66f9 mod_bosh: Add error callback for xmlhandlers, to handle the case of invalid or unusable XML in the request payload Matthew Wild <mwild1@gmail.com> parents: 3439 diff changeset	458 return;
cc2dc55e66f9 mod_bosh: Add error callback for xmlhandlers, to handle the case of invalid or unusable XML in the request payload Matthew Wild <mwild1@gmail.com> parents: 3439 diff changeset	459 end
5776 bd0ff8ae98a8 Remove all trailing whitespace Florian Zeitz <florob@babelmonkeys.de> parents: 5748 diff changeset	460
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	461 local session = sessions[context.sid];
3447 cc2dc55e66f9 mod_bosh: Add error callback for xmlhandlers, to handle the case of invalid or unusable XML in the request payload Matthew Wild <mwild1@gmail.com> parents: 3439 diff changeset	462 if error == "stream-error" then -- Remote stream error, we close normally
cc2dc55e66f9 mod_bosh: Add error callback for xmlhandlers, to handle the case of invalid or unusable XML in the request payload Matthew Wild <mwild1@gmail.com> parents: 3439 diff changeset	463 session:close();
cc2dc55e66f9 mod_bosh: Add error callback for xmlhandlers, to handle the case of invalid or unusable XML in the request payload Matthew Wild <mwild1@gmail.com> parents: 3439 diff changeset	464 else
cc2dc55e66f9 mod_bosh: Add error callback for xmlhandlers, to handle the case of invalid or unusable XML in the request payload Matthew Wild <mwild1@gmail.com> parents: 3439 diff changeset	465 session:close({ condition = "bad-format", text = "Error processing stream" });
cc2dc55e66f9 mod_bosh: Add error callback for xmlhandlers, to handle the case of invalid or unusable XML in the request payload Matthew Wild <mwild1@gmail.com> parents: 3439 diff changeset	466 end
cc2dc55e66f9 mod_bosh: Add error callback for xmlhandlers, to handle the case of invalid or unusable XML in the request payload Matthew Wild <mwild1@gmail.com> parents: 3439 diff changeset	467 end
cc2dc55e66f9 mod_bosh: Add error callback for xmlhandlers, to handle the case of invalid or unusable XML in the request payload Matthew Wild <mwild1@gmail.com> parents: 3439 diff changeset	468
5660 df077bc8f019 mod_bosh: Make waiting_requests and dead_sessions shared to preserve across reloads Matthew Wild <mwild1@gmail.com> parents: 5658 diff changeset	469 local dead_sessions = module:shared("dead_sessions");
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	470 function on_timer()
660 b2c4a7ec31c6 Remove some old debugging code from mod_bosh Matthew Wild <mwild1@gmail.com> parents: 636 diff changeset	471 -- log("debug", "Checking for requests soon to timeout...");
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	472 -- Identify requests timing out within the next few seconds
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	473 local now = os_time() + 3;
4690 55f690fdc915 mod_bosh: Optimisation, store reply_before value as waiting_requests value (saves a lookup) Matthew Wild <mwild1@gmail.com> parents: 4684 diff changeset	474 for request, reply_before in pairs(waiting_requests) do
55f690fdc915 mod_bosh: Optimisation, store reply_before value as waiting_requests value (saves a lookup) Matthew Wild <mwild1@gmail.com> parents: 4684 diff changeset	475 if reply_before <= now then
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	476 log("debug", "%s was soon to timeout (at %d, now %d), sending empty response", tostring(request), reply_before, now);
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	477 -- Send empty response to let the
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	478 -- client know we're still here
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	479 if request.conn then
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	480 sessions[request.context.sid].send("");
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	481 end
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	482 end
9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	483 end
5776 bd0ff8ae98a8 Remove all trailing whitespace Florian Zeitz <florob@babelmonkeys.de> parents: 5748 diff changeset	484
679 9506bf204b1a Numerous BOSH improvements... handle client disconnects, either explicit or implicit through inactivity; allow specifying BOSH default parameters through config; fix to prevent prematurely closing request connections in some cases, before they were replied to Matthew Wild <mwild1@gmail.com> parents: 660 diff changeset	485 now = now - 3;
1864 b9389286eece mod_bosh: Fix for 'invalid key to next' error when 2 clients lose connection at the same time Matthew Wild <mwild1@gmail.com> parents: 1633 diff changeset	486 local n_dead_sessions = 0;
4436 aa79b3767f98 mod_bosh: Store time to destroy session in inactive_sessions, removing dependency on session.bosh_max_inactive in cleanup timer Matthew Wild <mwild1@gmail.com> parents: 4379 diff changeset	487 for session, close_after in pairs(inactive_sessions) do
aa79b3767f98 mod_bosh: Store time to destroy session in inactive_sessions, removing dependency on session.bosh_max_inactive in cleanup timer Matthew Wild <mwild1@gmail.com> parents: 4379 diff changeset	488 if close_after < now then
aa79b3767f98 mod_bosh: Store time to destroy session in inactive_sessions, removing dependency on session.bosh_max_inactive in cleanup timer Matthew Wild <mwild1@gmail.com> parents: 4379 diff changeset	489 (session.log or log)("debug", "BOSH client inactive too long, destroying session at %d", now);
aa79b3767f98 mod_bosh: Store time to destroy session in inactive_sessions, removing dependency on session.bosh_max_inactive in cleanup timer Matthew Wild <mwild1@gmail.com> parents: 4379 diff changeset	490 sessions[session.sid] = nil;
679 9506bf204b1a Numerous BOSH improvements... handle client disconnects, either explicit or implicit through inactivity; allow specifying BOSH default parameters through config; fix to prevent prematurely closing request connections in some cases, before they were replied to Matthew Wild <mwild1@gmail.com> parents: 660 diff changeset	491 inactive_sessions[session] = nil;
4436 aa79b3767f98 mod_bosh: Store time to destroy session in inactive_sessions, removing dependency on session.bosh_max_inactive in cleanup timer Matthew Wild <mwild1@gmail.com> parents: 4379 diff changeset	492 n_dead_sessions = n_dead_sessions + 1;
aa79b3767f98 mod_bosh: Store time to destroy session in inactive_sessions, removing dependency on session.bosh_max_inactive in cleanup timer Matthew Wild <mwild1@gmail.com> parents: 4379 diff changeset	493 dead_sessions[n_dead_sessions] = session;
679 9506bf204b1a Numerous BOSH improvements... handle client disconnects, either explicit or implicit through inactivity; allow specifying BOSH default parameters through config; fix to prevent prematurely closing request connections in some cases, before they were replied to Matthew Wild <mwild1@gmail.com> parents: 660 diff changeset	494 end
9506bf204b1a Numerous BOSH improvements... handle client disconnects, either explicit or implicit through inactivity; allow specifying BOSH default parameters through config; fix to prevent prematurely closing request connections in some cases, before they were replied to Matthew Wild <mwild1@gmail.com> parents: 660 diff changeset	495 end
1864 b9389286eece mod_bosh: Fix for 'invalid key to next' error when 2 clients lose connection at the same time Matthew Wild <mwild1@gmail.com> parents: 1633 diff changeset	496
b9389286eece mod_bosh: Fix for 'invalid key to next' error when 2 clients lose connection at the same time Matthew Wild <mwild1@gmail.com> parents: 1633 diff changeset	497 for i=1,n_dead_sessions do
b9389286eece mod_bosh: Fix for 'invalid key to next' error when 2 clients lose connection at the same time Matthew Wild <mwild1@gmail.com> parents: 1633 diff changeset	498 local session = dead_sessions[i];
b9389286eece mod_bosh: Fix for 'invalid key to next' error when 2 clients lose connection at the same time Matthew Wild <mwild1@gmail.com> parents: 1633 diff changeset	499 dead_sessions[i] = nil;
b9389286eece mod_bosh: Fix for 'invalid key to next' error when 2 clients lose connection at the same time Matthew Wild <mwild1@gmail.com> parents: 1633 diff changeset	500 sm_destroy_session(session, "BOSH client silent for over "..session.bosh_max_inactive.." seconds");
b9389286eece mod_bosh: Fix for 'invalid key to next' error when 2 clients lose connection at the same time Matthew Wild <mwild1@gmail.com> parents: 1633 diff changeset	501 end
3684 bd071e3901dc mod_bosh: Use util.timer for timers instead of server.addtimer. Waqas Hussain <waqas20@gmail.com> parents: 3542 diff changeset	502 return 1;
636 9c9c671ecc50 Initial mod_bosh, works, kind of, but quite incomplete Matthew Wild <mwild1@gmail.com> parents: diff changeset	503 end
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	504 module:add_timer(1, on_timer);
701 dc67e3cffff4 BOSH: Allow BOSH servers to be configured through config file Matthew Wild <mwild1@gmail.com> parents: 693 diff changeset	505
4880 6d96e2e717c1 mod_bosh: Set Content-Type to text/html for GET response (thanks Medics) Matthew Wild <mwild1@gmail.com> parents: 4769 diff changeset	506
6d96e2e717c1 mod_bosh: Set Content-Type to text/html for GET response (thanks Medics) Matthew Wild <mwild1@gmail.com> parents: 4769 diff changeset	507 local GET_response = {
6d96e2e717c1 mod_bosh: Set Content-Type to text/html for GET response (thanks Medics) Matthew Wild <mwild1@gmail.com> parents: 4769 diff changeset	508 headers = {
6d96e2e717c1 mod_bosh: Set Content-Type to text/html for GET response (thanks Medics) Matthew Wild <mwild1@gmail.com> parents: 4769 diff changeset	509 content_type = "text/html";
6d96e2e717c1 mod_bosh: Set Content-Type to text/html for GET response (thanks Medics) Matthew Wild <mwild1@gmail.com> parents: 4769 diff changeset	510 };
6d96e2e717c1 mod_bosh: Set Content-Type to text/html for GET response (thanks Medics) Matthew Wild <mwild1@gmail.com> parents: 4769 diff changeset	511 body = [[<html><body>
6d96e2e717c1 mod_bosh: Set Content-Type to text/html for GET response (thanks Medics) Matthew Wild <mwild1@gmail.com> parents: 4769 diff changeset	512 <p>It works! Now point your BOSH client to this URL to connect to Prosody.</p>
6d96e2e717c1 mod_bosh: Set Content-Type to text/html for GET response (thanks Medics) Matthew Wild <mwild1@gmail.com> parents: 4769 diff changeset	513 <p>For more information see <a href="http://prosody.im/doc/setting_up_bosh">Prosody: Setting up BOSH</a>.</p>
6d96e2e717c1 mod_bosh: Set Content-Type to text/html for GET response (thanks Medics) Matthew Wild <mwild1@gmail.com> parents: 4769 diff changeset	514 </body></html>]];
6d96e2e717c1 mod_bosh: Set Content-Type to text/html for GET response (thanks Medics) Matthew Wild <mwild1@gmail.com> parents: 4769 diff changeset	515 };
6d96e2e717c1 mod_bosh: Set Content-Type to text/html for GET response (thanks Medics) Matthew Wild <mwild1@gmail.com> parents: 4769 diff changeset	516
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	517 function module.add_host(module)
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	518 module:depends("http");
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	519 module:provides("http", {
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	520 default_path = "/http-bind";
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	521 route = {
4880 6d96e2e717c1 mod_bosh: Set Content-Type to text/html for GET response (thanks Medics) Matthew Wild <mwild1@gmail.com> parents: 4769 diff changeset	522 ["GET"] = GET_response;
6d96e2e717c1 mod_bosh: Set Content-Type to text/html for GET response (thanks Medics) Matthew Wild <mwild1@gmail.com> parents: 4769 diff changeset	523 ["GET /"] = GET_response;
4725 d085db6285db mod_bosh: Add routes without trailing-'/', so that both /http-bind and /http-bind/ work again Matthew Wild <mwild1@gmail.com> parents: 4697 diff changeset	524 ["OPTIONS"] = handle_OPTIONS;
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	525 ["OPTIONS /"] = handle_OPTIONS;
4725 d085db6285db mod_bosh: Add routes without trailing-'/', so that both /http-bind and /http-bind/ work again Matthew Wild <mwild1@gmail.com> parents: 4697 diff changeset	526 ["POST"] = handle_POST;
4692 8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	527 ["POST /"] = handle_POST;
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	528 };
8e7c683d78ca mod_bosh: Large commit to update to mod_http/net.http.server APIs. Becomes a shared module. Matthew Wild <mwild1@gmail.com> parents: 4690 diff changeset	529 });
2354 5a00668ba0ab mod_bosh: Delay setup until after server is started. Waqas Hussain <waqas20@gmail.com> parents: 2099 diff changeset	530 end

prosody

17e42f793341

plugins/mod_bosh.lua

Software / code / prosody

Annotate

plugins/mod_bosh.lua @ 7653:17e42f793341

Software `/` code `/` prosody