Software / code / prosody
Changeset
13187:fe1229919070
mod_storage_internal: Implement efficient deletion of oldest archive items
Using the new shift function in datamanager, either the oldest items are
removed or all the later items are moved into a new file that replaces
the old.
Hidden behind a feature flag for now.
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Wed, 12 Jul 2023 15:03:24 +0200 |
| parents | 13186:affaf6d08d26 |
| children | 13188:96df571b5941 |
| files | plugins/mod_storage_internal.lua |
| diffstat | 1 files changed, 22 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/plugins/mod_storage_internal.lua Wed Jun 07 00:39:30 2023 +0200 +++ b/plugins/mod_storage_internal.lua Wed Jul 12 15:03:24 2023 +0200 @@ -14,6 +14,8 @@ local archive_item_limit = module:get_option_number("storage_archive_item_limit", 10000); local archive_item_count_cache = cache.new(module:get_option("storage_archive_item_limit_cache_size", 1000)); +local use_shift = module:get_option_boolean("storage_archive_experimental_fast_delete", false); + local driver = {}; function driver:open(store, typ) @@ -342,12 +344,32 @@ return datamanager.users(host, self.store, "list"); end +function archive:trim(username, to_when) + local list, err = datamanager.list_open(username, host, self.store); + if not list then return list,err;end + -- luacheck: ignore 211/exact + local i, exact = binary_search(list, function(item) + local when = item.when or datetime.parse(item.attr.stamp); + return to_when - when; + end); + -- TODO if exact then ... off by one? + if i == 1 then return 0; end + local ok, err = datamanager.list_shift(username, host, self.store, i); + if not ok then return ok, err; end + return i-1; +end + function archive:delete(username, query) local cache_key = jid_join(username, host, self.store); if not query or next(query) == nil then archive_item_count_cache:set(cache_key, nil); return datamanager.list_store(username, host, self.store, nil); end + + if use_shift and next(query) == "end" and next(query, "end") == nil then + return self:trim(username, query["end"]); + end + local items, err = datamanager.list_load(username, host, self.store); if not items then if err then
