Changeset

6760:e45a58c72609

util.sql: Use appropriate collation for the chosen character set - fixes MySQL silently ignoring our SET NAMES command when we use utf8mb4
author Matthew Wild <mwild1@gmail.com>
date Wed, 08 Jul 2015 15:06:20 +0100
parents 6759:fb952032f83e
children 6761:b20efae224c9
files util/sql.lua
diffstat 1 files changed, 1 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/util/sql.lua	Wed Jul 08 15:04:23 2015 +0100
+++ b/util/sql.lua	Wed Jul 08 15:06:20 2015 +0100
@@ -268,12 +268,12 @@
 	local set_names_query = "SET NAMES '%s';"
 	local charset = "utf8";
 	if driver == "MySQL" then
-		set_names_query = set_names_query:gsub(";$", " COLLATE 'utf8_bin';");
 		local ok, charsets = self:transaction(function()
 			return self:select"SELECT `CHARACTER_SET_NAME` FROM `information_schema`.`CHARACTER_SETS` WHERE `CHARACTER_SET_NAME` LIKE 'utf8%' ORDER BY MAXLEN DESC LIMIT 1;";
 		end);
 		local row = ok and charsets();
 		charset = row and row[1] or charset;
+		set_names_query = set_names_query:gsub(";$", (" COLLATE '%s';"):format(charset.."_bin"));
 	end
 	self.charset = charset;
 	return self:transaction(function() return self:execute(set_names_query:format(charset)); end);