Software / code / prosody
Changeset
12444:b33558969b3e 0.12
mod_http (and dependent modules): Make CORS opt-in by default (fixes #1731)
The same-origin policy enforced by browsers is a security measure that should
only be turned off when it is safe to do so. It is safe to do so in Prosody's
default modules, but people may load third-party modules that are unsafe.
Therefore we have flipped the default, so that modules must explicitly opt in
to having CORS headers added on their requests.
| author | Matthew Wild <mwild1@gmail.com> |
|---|---|
| date | Mon, 28 Mar 2022 14:53:24 +0100 |
| parents | 12443:17d87fb2312a |
| children | 12445:8d5fa022721c 12446:e54b8a5e35ad |
| files | plugins/mod_bosh.lua plugins/mod_http.lua plugins/mod_http_file_share.lua plugins/mod_websocket.lua |
| diffstat | 4 files changed, 8 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/plugins/mod_bosh.lua Mon Mar 28 14:40:21 2022 +0100 +++ b/plugins/mod_bosh.lua Mon Mar 28 14:53:24 2022 +0100 @@ -547,6 +547,9 @@ module:depends("http"); module:provides("http", { default_path = "/http-bind"; + cors = { + enabled = true; + }; route = { ["GET"] = GET_response; ["GET /"] = GET_response;
--- a/plugins/mod_http.lua Mon Mar 28 14:40:21 2022 +0100 +++ b/plugins/mod_http.lua Mon Mar 28 14:53:24 2022 +0100 @@ -163,7 +163,7 @@ local cors = cors_overrides[app_name] or event.item.cors; if cors then - if cors.enabled ~= false then + if cors.enabled == true then if cors.credentials ~= nil then app_credentials = cors.credentials; end
--- a/plugins/mod_http_file_share.lua Mon Mar 28 14:40:21 2022 +0100 +++ b/plugins/mod_http_file_share.lua Mon Mar 28 14:53:24 2022 +0100 @@ -578,6 +578,7 @@ module:provides("http", { streaming_uploads = true; cors = { + enabled = true; credentials = true; headers = { Authorization = true;
--- a/plugins/mod_websocket.lua Mon Mar 28 14:40:21 2022 +0100 +++ b/plugins/mod_websocket.lua Mon Mar 28 14:53:24 2022 +0100 @@ -355,6 +355,9 @@ module:provides("http", { name = "websocket"; default_path = "xmpp-websocket"; + cors = { + enabled = true; + }; route = { ["GET"] = handle_request; ["GET /"] = handle_request;
