Changeset

9517:b1c6ede17592

util.promise: Add promise.try()
author Matthew Wild <mwild1@gmail.com>
date Thu, 18 Oct 2018 18:03:31 +0100
parents 9516:038446c50630
children 9518:a62fa766d8f3
files spec/util_promise_spec.lua util/promise.lua
diffstat 2 files changed, 57 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/spec/util_promise_spec.lua	Thu Oct 18 18:00:54 2018 +0100
+++ b/spec/util_promise_spec.lua	Thu Oct 18 18:03:31 2018 +0100
@@ -331,4 +331,55 @@
 			assert.spy(on_finally_err).was_called_with(test_error);
 		end);
 	end);
+	describe("try()", function ()
+		it("works with functions that return a promise", function ()
+			local resolve;
+			local p = promise.try(function ()
+				return promise.new(function (_resolve)
+					resolve = _resolve;
+				end);
+			end);
+			assert.is_function(resolve);
+			local on_resolved = spy.new(function () end);
+			p:next(on_resolved);
+			assert.spy(on_resolved).was_not_called();
+			resolve("foo");
+			assert.spy(on_resolved).was_called_with("foo");
+		end);
+
+		it("works with functions that return a value", function ()
+			local p = promise.try(function ()
+				return "foo";
+			end);
+			local on_resolved = spy.new(function () end);
+			p:next(on_resolved);
+			assert.spy(on_resolved).was_called_with("foo");
+		end);
+
+		it("works with functions that return a promise that rejects", function ()
+			local reject;
+			local p = promise.try(function ()
+				return promise.new(function (_, _reject)
+					reject = _reject;
+				end);
+			end);
+			assert.is_function(reject);
+			local on_rejected = spy.new(function () end);
+			p:catch(on_rejected);
+			assert.spy(on_rejected).was_not_called();
+			reject("foo");
+			assert.spy(on_rejected).was_called_with("foo");
+		end);
+
+		it("works with functions that throw errors", function ()
+			local test_error = {};
+			local p = promise.try(function ()
+				error(test_error);
+			end);
+			local on_rejected = spy.new(function () end);
+			p:catch(on_rejected);
+			assert.spy(on_rejected).was_called(1);
+			assert.spy(on_rejected).was_called_with(test_error);
+		end);
+	end);
 end);
--- a/util/promise.lua	Thu Oct 18 18:00:54 2018 +0100
+++ b/util/promise.lua	Thu Oct 18 18:03:31 2018 +0100
@@ -51,6 +51,7 @@
 		if resolved then return; end
 		resolved = true;
 		if is_promise(e) then
+			print ("WOAH") assert(false)
 			e:next(new_resolve_functions(p));
 		elseif promise_settle(p, "rejected", next_rejected, p._pending_on_rejected, e) then
 			p.reason = e;
@@ -117,6 +118,10 @@
 	end);
 end
 
+local function try(f)
+	return resolve():next(function () return f(); end);
+end
+
 function promise_methods:next(on_fulfilled, on_rejected)
 	return new(function (resolve, reject) --luacheck: ignore 431/resolve 431/reject
 		self:_next(
@@ -142,4 +147,5 @@
 	reject = reject;
 	all = all;
 	race = race;
+	try = try;
 }