Software / code / prosody
Changeset
10484:b13a31cea7d9
net.connect: Add some TODOs and FIXMEs
And mention issue numbers: #1246, #1428 and #1429
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Sat, 07 Dec 2019 17:05:00 +0100 |
| parents | 10483:c12a24f0a385 |
| children | 10485:913276ba0c47 |
| files | net/connect.lua net/resolvers/basic.lua net/resolvers/service.lua |
| diffstat | 3 files changed, 10 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/net/connect.lua Wed Dec 04 22:37:20 2019 +0100 +++ b/net/connect.lua Sat Dec 07 17:05:00 2019 +0100 @@ -3,8 +3,10 @@ local new_id = require "util.id".short; -- TODO Respect use_ipv4, use_ipv6 +-- TODO #1246 Happy Eyeballs -- FIXME Error propagation from resolvers doesn't work --- TODO Try to share DNS resolver object and close it afterwards +-- FIXME #1428 Reuse DNS resolver object between service and basic resolver +-- FIXME #1429 Close DNS resolver object when done local pending_connection_methods = {}; local pending_connection_mt = {
--- a/net/resolvers/basic.lua Wed Dec 04 22:37:20 2019 +0100 +++ b/net/resolvers/basic.lua Sat Dec 07 17:05:00 2019 +0100 @@ -7,6 +7,10 @@ local methods = {}; local resolver_mt = { __index = methods }; +-- TODO Respect use_ipv4, use_ipv6 +-- FIXME #1428 Reuse DNS resolver object (from service resolver) +-- FIXME #1429 Close DNS resolver object when done + -- Find the next target to connect to, and -- pass it to cb() function methods:next(cb)
--- a/net/resolvers/service.lua Wed Dec 04 22:37:20 2019 +0100 +++ b/net/resolvers/service.lua Sat Dec 07 17:05:00 2019 +0100 @@ -4,6 +4,9 @@ local idna_to_ascii = require "util.encodings".idna.to_ascii; local unpack = table.unpack or unpack; -- luacheck: ignore 113 +-- FIXME #1428 Reuse DNS resolver object (pass to basic resorver) +-- FIXME #1429 Close DNS resolver object when done + local methods = {}; local resolver_mt = { __index = methods };
