Software / code / prosody
Changeset
13496:3e6d5738ea09
MUC: Don't default component admins to being room owners
This change has various technical and social benefits. If ownership of a MUC
is really needed, it can be gained using the 'Set affiliation' ad-hoc command
or prosodyctl shell.
Example client incompatibility with the old behaviour:
- https://github.com/monal-im/Monal/issues/1085
| author | Matthew Wild <mwild1@gmail.com> |
|---|---|
| date | Tue, 18 Jun 2024 15:08:30 +0100 |
| parents | 13495:47e1df2d0a37 |
| children | 13498:aefbc76ac8d2 |
| files | CHANGES plugins/muc/mod_muc.lua |
| diffstat | 2 files changed, 5 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/CHANGES Thu May 23 17:39:20 2024 +0100 +++ b/CHANGES Tue Jun 18 15:08:30 2024 +0100 @@ -16,6 +16,10 @@ ### MUC +- Component admins are no longer room owners by default. This can be reverted + to the old behaviour with `component_admins_as_room_owners = true`, but this + has known incompatibilities with some clients. Instead, use the shell or + ad-hoc commands to gain ownership of rooms when necessary. - Permissions updates: - Room creation restricted to local users (of the parent host) by default - restrict_room_creation = true restricts to admins, false disables all restrictions
--- a/plugins/muc/mod_muc.lua Thu May 23 17:39:20 2024 +0100 +++ b/plugins/muc/mod_muc.lua Tue Jun 18 15:08:30 2024 +0100 @@ -125,7 +125,7 @@ ":list-rooms"; }); -if module:get_option_boolean("component_admins_as_room_owners", true) then +if module:get_option_boolean("component_admins_as_room_owners", false) then -- Monkey patch to make server admins room owners local _get_affiliation = room_mt.get_affiliation; function room_mt:get_affiliation(jid)
