Changeset

7740:26a7186a40c6

core.stanza_router: Separate iq type check from child count check
author Kim Alvefur <zash@zash.se>
date Fri, 25 Nov 2016 05:08:09 +0100
parents 7739:0356216c474c
children 7741:fd277ee3ac57
files core/stanza_router.lua
diffstat 1 files changed, 5 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/core/stanza_router.lua	Fri Nov 25 05:06:13 2016 +0100
+++ b/core/stanza_router.lua	Fri Nov 25 05:08:09 2016 +0100
@@ -67,12 +67,15 @@
 			return handle_unhandled_stanza(origin.host, origin, stanza);
 		end
 		if name == "iq" then
-			if not iq_types[st_type] or ((st_type == "set" or st_type == "get") and (#stanza.tags ~= 1)) then
-				origin.send(st.error_reply(stanza, "modify", "bad-request", "Invalid IQ type or incorrect number of children"));
+			if not iq_types[st_type] then
+				origin.send(st.error_reply(stanza, "modify", "bad-request", "Invalid IQ type"));
 				return;
 			elseif not stanza.attr.id then
 				origin.send(st.error_reply(stanza, "modify", "bad-request", "Missing required 'id' attribute"));
 				return;
+			elseif (st_type == "set" or st_type == "get") and (#stanza.tags ~= 1) then
+				origin.send(st.error_reply(stanza, "modify", "bad-request", "Incorrect number of children for IQ stanz"));
+				return;
 			end
 		end