Software / code / prosody
Changeset
9120:01fc8ba0a7fa
mod_pubsub: Use util.pubsub API for retrieving node config instead
Normalizes access control to the 'get_configuration' capability
Thanks pep.
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Sun, 05 Aug 2018 19:12:49 +0200 |
| parents | 9119:5444d4a8ad90 |
| children | 9121:e5eb36ee07a2 |
| files | plugins/mod_pubsub/pubsub.lib.lua |
| diffstat | 1 files changed, 3 insertions(+), 9 deletions(-) [+] |
line wrap: on
line diff
--- a/plugins/mod_pubsub/pubsub.lib.lua Sun Aug 05 19:12:29 2018 +0200 +++ b/plugins/mod_pubsub/pubsub.lib.lua Sun Aug 05 19:12:49 2018 +0200 @@ -632,18 +632,12 @@ return true; end - if not service:may(node, stanza.attr.from, "configure") then - origin.send(pubsub_error_reply(stanza, "forbidden")); + local ok, node_config = service:get_node_config(node, stanza.attr.from); + if not ok then + origin.send(pubsub_error_reply(stanza, node_config)); return true; end - local node_obj = service.nodes[node]; - if not node_obj then - origin.send(pubsub_error_reply(stanza, "item-not-found")); - return true; - end - - local node_config = node_obj.config; local pubsub_form_data = config_to_xep0060(node_config); local reply = st.reply(stanza) :tag("pubsub", { xmlns = xmlns_pubsub_owner })
