# HG changeset patch
# User Kim Alvefur <zash@zash.se>
# Date 1637757793 -3600
# Node ID f752427a5214fc0e3578fe3d2e6a1c1ae8ae7029
# Parent  92925f1320e75d0725b4358f5d9ed46d92dba053
mod_external_services: Warn about missing recommended fields

These are RECOMMENDED in XEP-0215 so most likely a mistake if they are
left out.

Of the two REQUIRED fields, 'host' falls back to module.host and 'type'
rejects the whole item.

diff -r 92925f1320e7 -r f752427a5214 plugins/mod_external_services.lua
--- a/plugins/mod_external_services.lua	Wed Nov 24 20:12:22 2021 +0100
+++ b/plugins/mod_external_services.lua	Wed Nov 24 13:43:13 2021 +0100
@@ -63,12 +63,16 @@
 	end
 	if type(item.transport) == "string" then
 		srv.transport = item.transport;
+	else
+		module:log("warn", "Service missing recommended 'transport' field: %q", item);
 	end
 	if type(item.host) == "string" then
 		srv.host = item.host;
 	end
 	if type(item.port) == "number" then
 		srv.port = item.port;
+	elseif not srv.port then
+		module:log("warn", "Service missing recommended 'port' field: %q", item);
 	end
 	if type(item.username) == "string" then
 		srv.username = item.username;