# HG changeset patch
# User Matthew Wild <mwild1@gmail.com>
# Date 1731681401 0
# Node ID eedae7d4778401de2e9bbc99b81c59abc92f025a
# Parent  d6545c533ce28b59dd55dcd27f376917cdd85119
MUC: optimizations for broadcast of visitor presence (thanks Jitsi team)

This avoids doing performing unnecessary work in the case of visitors joining
a MUC, no functionality changes are intended.

diff -r d6545c533ce2 -r eedae7d47784 plugins/muc/muc.lib.lua
--- a/plugins/muc/muc.lib.lua	Fri Nov 08 10:28:29 2024 +0000
+++ b/plugins/muc/muc.lib.lua	Fri Nov 15 14:36:41 2024 +0000
@@ -304,10 +304,10 @@
 	-- General populace
 	for occupant_nick, n_occupant in self:each_occupant() do
 		if occupant_nick ~= occupant.nick then
-			local pr = get_p(n_occupant);
 			if broadcast_roles[occupant.role or "none"] or force_unavailable then
-				self:route_to_occupant(n_occupant, pr);
+				self:route_to_occupant(n_occupant, get_p(n_occupant));
 			elseif prev_role and broadcast_roles[prev_role] then
+				local pr = get_p(n_occupant);
 				pr.attr.type = 'unavailable';
 				self:route_to_occupant(n_occupant, pr);
 			end
@@ -339,16 +339,14 @@
 	local broadcast_bare_jids = {}; -- Track which bare JIDs we have sent presence for
 	for occupant_jid, occupant in self:each_occupant() do
 		broadcast_bare_jids[occupant.bare_jid] = true;
-		if filter == nil or filter(occupant_jid, occupant) then
+		if (filter == nil or filter(occupant_jid, occupant)) and (to_bare == occupant.bare_jid or broadcast_roles[occupant.role or "none"]) then
 			local x = st.stanza("x", {xmlns='http://jabber.org/protocol/muc#user'});
 			self:build_item_list(occupant, x, is_anonymous and to_bare ~= occupant.bare_jid); -- can always see your own jids
 			local pres = st.clone(occupant:get_presence());
 			pres.attr.to = to;
 			pres:add_child(x);
 			module:fire_event("muc-build-occupant-presence", { room = self, occupant = occupant, stanza = pres });
-			if to_bare == occupant.bare_jid or broadcast_roles[occupant.role or "none"] then
-				self:route_stanza(pres);
-			end
+			self:route_stanza(pres);
 		end
 	end
 	if broadcast_roles.none then