# HG changeset patch # User Kim Alvefur # Date 1592132270 -7200 # Node ID ea4a7619058f69fc3b197baada65f85034406b3f # Parent 558f0555ba02979320f93a39c4f7fe447c4ad524 util.prosodyctl.check: Fix traceback by handling SRV '.' target to The IDNA to-ASCII operation returns nil in this case, which causes an error in net.dns diff -r 558f0555ba02 -r ea4a7619058f util/prosodyctl/check.lua --- a/util/prosodyctl/check.lua Sun Jun 14 09:40:08 2020 +0100 +++ b/util/prosodyctl/check.lua Sun Jun 14 12:57:50 2020 +0200 @@ -299,6 +299,10 @@ local res = dns.lookup("_xmpp-client._tcp."..idna.to_ascii(host)..".", "SRV"); if res then for _, record in ipairs(res) do + if record.srv.target == "." then -- TODO is this an error if mod_c2s is enabled? + print(" 'xmpp-client' service disabled by pointing to '.'"); -- FIXME Explain better what this is + break; + end target_hosts:add(record.srv.target); if not c2s_ports:contains(record.srv.port) then print(" SRV target "..record.srv.target.." contains unknown client port: "..record.srv.port); @@ -317,6 +321,10 @@ local res = dns.lookup("_xmpp-server._tcp."..idna.to_ascii(host)..".", "SRV"); if res then for _, record in ipairs(res) do + if record.srv.target == "." then -- TODO Is this an error if mod_s2s is enabled? + print(" 'xmpp-server' service disabled by pointing to '.'"); -- FIXME Explain better what this is + break; + end target_hosts:add(record.srv.target); if not s2s_ports:contains(record.srv.port) then print(" SRV target "..record.srv.target.." contains unknown server port: "..record.srv.port);