# HG changeset patch # User Kim Alvefur # Date 1651921309 -7200 # Node ID e9ea5c88def00dd7e41557f0c6b7bd95863a8bb4 # Parent a44c328028ad7e36a35ae94321744d232a8e555e mod_s2s: Don't bounce queued error stanzas (thanks Martin) The check for the type attr was lost in 11765f0605ec leading to attempts to create error replies for error stanzas, which util.stanza rejects. Tested by sending which produced a traceback previously. diff -r a44c328028ad -r e9ea5c88def0 plugins/mod_s2s.lua --- a/plugins/mod_s2s.lua Fri May 06 17:09:06 2022 +0100 +++ b/plugins/mod_s2s.lua Sat May 07 13:01:49 2022 +0200 @@ -147,7 +147,7 @@ reason_text = reason; end for i, stanza in ipairs(sendq) do - if not stanza.attr.xmlns and bouncy_stanzas[stanza.name] then + if not stanza.attr.xmlns and bouncy_stanzas[stanza.name] and stanza.attr.type ~= "error" and stanza.attr.type ~= "result" then local reply = st.error_reply( stanza, error_type,