# HG changeset patch
# User Matthew Wild <mwild1@gmail.com>
# Date 1647689901 0
# Node ID dd47adf74e9310d09deccf5572d851567d45837b
# Parent  19fd28239e738e883dcac838decb4b20148ccdc0
mod_admin_socket: Improve error reporting when socket can't be created (fixes #1719)

diff -r 19fd28239e73 -r dd47adf74e93 plugins/mod_admin_socket.lua
--- a/plugins/mod_admin_socket.lua	Sat Mar 19 11:09:10 2022 +0000
+++ b/plugins/mod_admin_socket.lua	Sat Mar 19 11:38:21 2022 +0000
@@ -62,8 +62,16 @@
 	sock = unix.stream();
 	sock:settimeout(0);
 	os.remove(socket_path);
-	assert(sock:bind(socket_path));
-	assert(sock:listen());
+	local ok, err = sock:bind(socket_path);
+	if not ok then
+		module:log_status("error", "Unable to bind admin socket %s: %s", socket_path, err);
+		return;
+	end
+	local ok, err = sock:listen();
+	if not ok then
+		module:log_status("error", "Unable to listen on admin socket %s: %s", socket_path, err);
+		return;
+	end
 	if server.wrapserver then
 		conn = server.wrapserver(sock, socket_path, 0, listeners);
 	else