# HG changeset patch
# User Matthew Wild <mwild1@gmail.com>
# Date 1731061709 0
# Node ID d6545c533ce28b59dd55dcd27f376917cdd85119
# Parent  1a915c2e0fa4832d35d5051e1c1e80cedacda450
mod_bookmarks: Clarify log messages on failure to sync to modern PEP bookmarks

Previously the error messages said that it failed to "publish" to PEP, but
sometimes a sync involves removing items, which can be confusing.

The log was also the same for both legacy PEP and private XML bookmarks.
Having different log messages makes it easier to debug the cause and location
of any sync errors.

diff -r 1a915c2e0fa4 -r d6545c533ce2 plugins/mod_bookmarks.lua
--- a/plugins/mod_bookmarks.lua	Fri Nov 08 10:24:42 2024 +0000
+++ b/plugins/mod_bookmarks.lua	Fri Nov 08 10:28:29 2024 +0000
@@ -314,7 +314,7 @@
 
 	local ok, err = publish_to_pep(session.full_jid, bookmarks, true);
 	if not ok then
-		module:log("error", "Failed to publish to PEP bookmarks for %s@%s: %s", session.username, session.host, err);
+		module:log("error", "Failed to sync legacy bookmarks to PEP for %s@%s: %s", session.username, session.host, err);
 		session.send(st.error_reply(stanza, "cancel", "internal-server-error", "Failed to store bookmarks to PEP"));
 		return true;
 	end
@@ -340,7 +340,7 @@
 
 	local ok, err = publish_to_pep(session.full_jid, bookmarks, true);
 	if not ok then
-		module:log("error", "Failed to publish to PEP bookmarks for %s@%s: %s", session.username, session.host, err);
+		module:log("error", "Failed to sync private XML bookmarks to PEP for %s@%s: %s", session.username, session.host, err);
 		session.send(st.error_reply(stanza, "cancel", "internal-server-error", "Failed to store bookmarks to PEP"));
 		return true;
 	end