# HG changeset patch
# User Kim Alvefur <zash@zash.se>
# Date 1731247826 -3600
# Node ID d3649ae194ab7022d5f3526099834cd96882b75c
# Parent  42b98ee73ca8ffbd635b86ac2d0c53feedeee3d5
mod_s2s: Clone queued outgoing stanzas to prevent changes

This clone call was lost in 902d25cd0557

Affects e.g. presence broadcasts, where the same stanza is sent many
times while mutating the 'to' attribute.

diff -r 42b98ee73ca8 -r d3649ae194ab plugins/mod_s2s.lua
--- a/plugins/mod_s2s.lua	Sun Nov 10 15:06:00 2024 +0100
+++ b/plugins/mod_s2s.lua	Sun Nov 10 15:10:26 2024 +0100
@@ -227,7 +227,7 @@
 	-- Store in buffer
 	host_session.bounce_sendq = bounce_sendq;
 	host_session.sendq = queue.new(sendq_size);
-	host_session.sendq:push(stanza);
+	host_session.sendq:push(st.clone(stanza));
 	log("debug", "stanza [%s] queued until connection complete", stanza.name);
 	-- FIXME Cleaner solution to passing extra data from resolvers to net.server
 	-- This mt-clone allows resolvers to add extra data, currently used for DANE TLSA records