# HG changeset patch
# User Kim Alvefur <zash@zash.se>
# Date 1585946147 -7200
# Node ID c4b49939b471556d7ed7ff98f2e6771ce07a201e
# Parent  6b63ba5b078a1013eb4a51a3ede8a48d9cff39fa
mod_vcard4: Report correct error condition (fixes #1521)

On error, the second return value is the error condition, not the third.

diff -r 6b63ba5b078a -r c4b49939b471 plugins/mod_vcard4.lua
--- a/plugins/mod_vcard4.lua	Sun Sep 29 15:05:17 2019 +0200
+++ b/plugins/mod_vcard4.lua	Fri Apr 03 22:35:47 2020 +0200
@@ -14,9 +14,9 @@
 	local ok, id, item = pep_service:get_last_item("urn:xmpp:vcard4", stanza.attr.from);
 	if ok and item then
 		origin.send(st.reply(stanza):add_child(item.tags[1]));
-	elseif item == "item-not-found" or not id then
+	elseif id == "item-not-found" or not id then
 		origin.send(st.error_reply(stanza, "cancel", "item-not-found"));
-	elseif item == "forbidden" then
+	elseif id == "forbidden" then
 		origin.send(st.error_reply(stanza, "auth", "forbidden"));
 	else
 		origin.send(st.error_reply(stanza, "modify", "undefined-condition"));