# HG changeset patch
# User Waqas Hussain <waqas20@gmail.com>
# Date 1296258176 -18000
# Node ID c3508071af47414374217ec37df2e0d6cdd0cf02
# Parent  c86b68abe12ede81ad9313b61edb741aa6bf2662
stanza_router: Return a <bad-request/> error on invalid IQ type.

diff -r c86b68abe12e -r c3508071af47 core/stanza_router.lua
--- a/core/stanza_router.lua	Sat Jan 29 04:42:05 2011 +0500
+++ b/core/stanza_router.lua	Sat Jan 29 04:42:56 2011 +0500
@@ -40,6 +40,7 @@
 	end
 end
 
+local iq_types = { set=true, get=true, result=true, error=true };
 function core_process_stanza(origin, stanza)
 	(origin.log or log)("debug", "Received[%s]: %s", origin.type, stanza:top_tag())
 
@@ -47,8 +48,8 @@
 	if stanza.attr.type == "error" and #stanza.tags == 0 then return; end -- TODO invalid stanza, log
 	if stanza.name == "iq" then
 		if not stanza.attr.id then stanza.attr.id = ""; end -- COMPAT Jabiru doesn't send the id attribute on roster requests
-		if (stanza.attr.type == "set" or stanza.attr.type == "get") and (#stanza.tags ~= 1) then
-			origin.send(st.error_reply(stanza, "modify", "bad-request"));
+		if not iq_types[stanza.attr.type] or ((stanza.attr.type == "set" or stanza.attr.type == "get") and (#stanza.tags ~= 1)) then
+			origin.send(st.error_reply(stanza, "modify", "bad-request", "Invalid IQ type or incorrect number of children"));
 			return;
 		end
 	end