# HG changeset patch
# User Matthew Wild <mwild1@gmail.com>
# Date 1675982045 0
# Node ID b56a2731bf00114aa53cceb34b3a7b62ccda060d
# Parent  0ed24f48b6a604dba3eb8a1a35989434a4db8255# Parent  09a53ed8f4d55e2dea1038e32b05c188572c2edb
Merge 0.12->trunk

diff -r 0ed24f48b6a6 -r b56a2731bf00 core/sessionmanager.lua
--- a/core/sessionmanager.lua	Tue Jan 31 16:27:55 2023 +0100
+++ b/core/sessionmanager.lua	Thu Feb 09 22:34:05 2023 +0000
@@ -138,10 +138,6 @@
 end
 
 local function destroy_session(session, err)
-	(session.log or log)("debug", "Destroying session for %s (%s@%s)%s",
-		session.full_jid or "(unknown)", session.username or "(unknown)",
-		session.host or "(unknown)", err and (": "..err) or "");
-
 	if session.destroyed then return; end
 
 	-- Remove session/resource from user's session list
@@ -150,9 +146,16 @@
 
 		-- Allow plugins to prevent session destruction
 		if host_session.events.fire_event("pre-resource-unbind", {session=session, error=err}) then
+			(session.log or log)("debug", "Resource unbind prevented by module");
 			return;
 		end
 
+		(session.log or log)("debug", "Unbinding resource for %s (%s@%s)%s",
+			session.full_jid or "(unknown)", session.username or "(unknown)",
+			session.host or "(unknown)", err and (": "..err) or "");
+
+		session.destroyed = true; -- Past this point the session is DOOMED!
+
 		host_session.sessions[session.username].sessions[session.resource] = nil;
 		full_sessions[session.full_jid] = nil;
 
@@ -163,6 +166,10 @@
 		end
 
 		host_session.events.fire_event("resource-unbind", {session=session, error=err});
+	else
+		(session.log or log)("debug", "Destroying unbound session for <%s@%s>%s",
+			session.username or "(unknown)", session.host or "(unknown)",
+			err and (": "..err) or "");
 	end
 
 	retire_session(session);