# HG changeset patch # User Matthew Wild # Date 1739460623 0 # Node ID acb87cc2d48bf61f3a20cda5d196517d5046360e # Parent 40c309f8b676e5c2910111a39718f640d9fd4623 mod_authz_internal: Fix return values of secondary role management methods usermanager expects (role, err) and (ok, err) diff -r 40c309f8b676 -r acb87cc2d48b plugins/mod_authz_internal.lua --- a/plugins/mod_authz_internal.lua Thu Feb 13 14:00:08 2025 +0000 +++ b/plugins/mod_authz_internal.lua Thu Feb 13 15:30:23 2025 +0000 @@ -180,14 +180,19 @@ end function add_user_secondary_role(user, role_name) - if not role_registry[role_name] then + local role = role_registry[role_name]; + if not role then return error("Cannot assign default user an unknown role: "..tostring(role_name)); end - role_map_store:set(user, role_name, true); + local ok, err = role_map_store:set(user, role_name, true); + if not ok then + return nil, err; + end + return role; end function remove_user_secondary_role(user, role_name) - role_map_store:set(user, role_name, nil); + return role_map_store:set(user, role_name, nil); end function get_user_secondary_roles(user)