# HG changeset patch
# User Matthew Wild <mwild1@gmail.com>
# Date 1428085224 -3600
# Node ID a455dac79f58cdb040a28df3cf93b86e8407bad8
# Parent  5d2346e7271670f2e3f983e4f9972ee7243bfe12
loggingmanager: Improve code structure (removes empty if branch)

diff -r 5d2346e72716 -r a455dac79f58 core/loggingmanager.lua
--- a/core/loggingmanager.lua	Fri Apr 03 19:13:35 2015 +0100
+++ b/core/loggingmanager.lua	Fri Apr 03 19:20:24 2015 +0100
@@ -45,16 +45,16 @@
 -- This function is called automatically when a new sink type is added [see apply_sink_rules()]
 local function add_rule(sink_config)
 	local sink_maker = log_sink_types[sink_config.to];
-	if sink_maker then
-		-- Create sink
-		local sink = sink_maker(sink_config);
+	if not sink_maker then
+		return; -- No such sink type
+	end
 
-		-- Set sink for all chosen levels
-		for level in pairs(get_levels(sink_config.levels or logging_levels)) do
-			logger.add_level_sink(level, sink);
-		end
-	else
-		-- No such sink type
+	-- Create sink
+	local sink = sink_maker(sink_config);
+
+	-- Set sink for all chosen levels
+	for level in pairs(get_levels(sink_config.levels or logging_levels)) do
+		logger.add_level_sink(level, sink);
 	end
 end