# HG changeset patch
# User Kim Alvefur <zash@zash.se>
# Date 1630347555 -7200
# Node ID a0e17b7c8b0546ad47b80cfcb7dc4c7c13bfd8d1
# Parent  ae565e49289a70ac3d26154965a306bcfd69f8db
mod_external_services: Factor out public function for converting to XML

Along with the previous commit, allows building the XML thing yourself,
should you wish to send it yourself or use it in a different context than
an iq reply.

API change: The 'reply' is removed from the event.

diff -r ae565e49289a -r a0e17b7c8b05 plugins/mod_external_services.lua
--- a/plugins/mod_external_services.lua	Mon Aug 30 00:11:58 2021 +0200
+++ b/plugins/mod_external_services.lua	Mon Aug 30 20:19:15 2021 +0200
@@ -131,34 +131,8 @@
 	return services;
 end
 
-local function handle_services(event)
-	local origin, stanza = event.origin, event.stanza;
-	local action = stanza.tags[1];
-
-	local user_bare = jid.bare(stanza.attr.from);
-	local user_host = jid.host(user_bare);
-	if not ((access:empty() and origin.type == "c2s") or access:contains(user_bare) or access:contains(user_host)) then
-		origin.send(st.error_reply(stanza, "auth", "forbidden"));
-		return true;
-	end
-
-	local reply = st.reply(stanza):tag("services", { xmlns = action.attr.xmlns });
-	local services = get_services();
-
-	local requested_type = action.attr.type;
-	if requested_type then
-		services:filter(function(item)
-			return item.type == requested_type;
-		end);
-	end
-
-	module:fire_event("external_service/services", {
-			origin = origin;
-			stanza = stanza;
-			reply = reply;
-			requested_type = requested_type;
-			services = services;
-		});
+function services_xml(services, name, namespace)
+	local reply = st.stanza(name or "services", { xmlns = namespace or "urn:xmpp:extdisco:2" });
 
 	for _, srv in ipairs(services) do
 		reply:tag("service", {
@@ -173,6 +147,38 @@
 			}):up();
 	end
 
+	return reply;
+end
+
+local function handle_services(event)
+	local origin, stanza = event.origin, event.stanza;
+	local action = stanza.tags[1];
+
+	local user_bare = jid.bare(stanza.attr.from);
+	local user_host = jid.host(user_bare);
+	if not ((access:empty() and origin.type == "c2s") or access:contains(user_bare) or access:contains(user_host)) then
+		origin.send(st.error_reply(stanza, "auth", "forbidden"));
+		return true;
+	end
+
+	local services = get_services();
+
+	local requested_type = action.attr.type;
+	if requested_type then
+		services:filter(function(item)
+			return item.type == requested_type;
+		end);
+	end
+
+	module:fire_event("external_service/services", {
+			origin = origin;
+			stanza = stanza;
+			requested_type = requested_type;
+			services = services;
+		});
+
+	local reply = st.reply(stanza):add_child(services_xml(services, action.name, action.attr.xmlns));
+
 	origin.send(reply);
 	return true;
 end
@@ -186,7 +192,6 @@
 		return true;
 	end
 
-	local reply = st.reply(stanza):tag("credentials", { xmlns = action.attr.xmlns });
 	local services = get_services();
 	services:filter(function (item)
 		return item.restricted;
@@ -206,7 +211,6 @@
 	module:fire_event("external_service/credentials", {
 			origin = origin;
 			stanza = stanza;
-			reply = reply;
 			requested_credentials = requested_credentials;
 			services = services;
 		});
@@ -217,18 +221,7 @@
 		return requested_credentials:contains(port_key) or requested_credentials:contains(portless_key);
 	end);
 
-	for _, srv in ipairs(services) do
-		reply:tag("service", {
-				type = srv.type;
-				transport = srv.transport;
-				host = srv.host;
-				port = srv.port and string.format("%d", srv.port) or nil;
-				username = srv.username;
-				password = srv.password;
-				expires = srv.expires and dt.datetime(srv.expires) or nil;
-				restricted = srv.restricted and "1" or nil;
-			}):up();
-	end
+	local reply = st.reply(stanza):add_child(services_xml(services, action.name, action.attr.xmlns));
 
 	origin.send(reply);
 	return true;