# HG changeset patch # User Kim Alvefur # Date 1614800934 -3600 # Node ID 926d53af9a7aaea4a4caa49a689deb422d90864f # Parent f768db80aee0b7de7aad22cfa2e9b09270fc9a68 net.resolvers.basic: Disable DANE for now, completely broken Turns out 'extra' is, at least for mod_s2s, the same table for *all* connections. diff -r f768db80aee0 -r 926d53af9a7a CHANGES --- a/CHANGES Wed Mar 03 18:42:54 2021 +0100 +++ b/CHANGES Wed Mar 03 20:48:54 2021 +0100 @@ -17,7 +17,6 @@ - `daemonize` option deprecated - SASL DIGEST-MD5 removed - Switch to libunbound for DNS queries -- DANE Support - mod_external_services (XEP-0215) - util.error for encapsulating errors - MUC: support for XEP-0421 occupant identifiers diff -r f768db80aee0 -r 926d53af9a7a net/resolvers/basic.lua --- a/net/resolvers/basic.lua Wed Mar 03 18:42:54 2021 +0100 +++ b/net/resolvers/basic.lua Wed Mar 03 20:48:54 2021 +0100 @@ -36,15 +36,14 @@ n = n - 1; if n > 0 then return; end self.targets = targets; + --[[ + -- TODO stash tlsa somewhere per connection + -- FIXME 'extra' here is not per connection if self.extra and self.extra.use_dane then if secure and tlsa[1] then - self.extra.tlsa = tlsa; - self.extra.dane_hostname = self.hostname; - else - self.extra.tlsa = nil; - self.extra.dane_hostname = nil; end end + --]] self:next(cb); end