# HG changeset patch # User Matthew Wild # Date 1734704462 0 # Node ID 836efad8483c9931061aa9fc30bb939fde79361b # Parent eedae7d4778401de2e9bbc99b81c59abc92f025a util.prosodyctl.check: Improve error handling of UDP socket setup (for #1803) Not necessarily a fix, but may give us more information about failure cases. diff -r eedae7d47784 -r 836efad8483c util/prosodyctl/check.lua --- a/util/prosodyctl/check.lua Fri Nov 15 14:36:41 2024 +0000 +++ b/util/prosodyctl/check.lua Fri Dec 20 14:21:02 2024 +0000 @@ -70,10 +70,22 @@ local ip = require "util.ip"; local stun = require "net.stun"; + local result = { warnings = {} }; + -- Create UDP socket for communication with the server local sock = assert(require "socket".udp()); - sock:setsockname("*", 0); - sock:setpeername(turn_service.host, turn_service.port); + do + local ok, err = sock:setsockname("*", 0); + if not ok then + result.error = "Unable to perform TURN test: setsockname: "..tostring(err); + return result; + end + ok, err = sock:setpeername(turn_service.host, turn_service.port); + if not ok then + result.error = "Unable to perform TURN test: setpeername: "..tostring(err); + return result; + end + end sock:settimeout(10); -- Helper function to receive a packet @@ -85,8 +97,6 @@ return stun.new_packet():deserialize(raw_packet); end - local result = { warnings = {} }; - -- Send a "binding" query, i.e. a request for our external IP/port local bind_query = stun.new_packet("binding", "request"); bind_query:add_attribute("software", "prosodyctl check turn");