# HG changeset patch # User Kim Alvefur # Date 1532882078 -7200 # Node ID 82dd435c942c5729fec21aaf95b54e4d1eb515be # Parent 69bc3144c2b7665b6cf8cd853015720de9fc213d mod_pep_plus: Fix boolean logic precedence (thanks Link Mauve) In case of 'from' subscription to a JID without node, eg a component, the condition becomes true and update_subscriptions() is called with contact_node = nil, which causes a traceback. diff -r 69bc3144c2b7 -r 82dd435c942c plugins/mod_pep_plus.lua --- a/plugins/mod_pep_plus.lua Sun Jul 29 00:17:41 2018 +0200 +++ b/plugins/mod_pep_plus.lua Sun Jul 29 18:34:38 2018 +0200 @@ -423,7 +423,7 @@ for jid, item in pairs(origin.roster) do -- for all interested contacts if jid then local contact_node, contact_host = jid_split(jid); - if contact_host == host and item.subscription == "both" or item.subscription == "from" then + if contact_host == host and (item.subscription == "both" or item.subscription == "from") then update_subscriptions(user_bare, contact_node, notify); end end