# HG changeset patch # User Matthew Wild # Date 1732208575 0 # Node ID 5d8fc1c4eb7ce2035e5f4dfc76a52c436a667499 # Parent 750ff9f579e249bafceb8edfa3d2220143411329 mod_smacks: Run session destruction code in session's async context This is the Right Thing and should fix various potential issues and race conditions. diff -r 750ff9f579e2 -r 5d8fc1c4eb7c plugins/mod_smacks.lua --- a/plugins/mod_smacks.lua Thu Nov 21 17:02:07 2024 +0000 +++ b/plugins/mod_smacks.lua Thu Nov 21 17:02:55 2024 +0000 @@ -541,13 +541,17 @@ return end - prosody.main_thread:run(function () - session.log("debug", "Destroying session for hibernating too long"); - save_old_session(session); - session.resumption_token = nil; - sessionmanager.destroy_session(session, "Hibernating too long"); - sessions_expired(1); - end); + session.thread:run({ + event = "callback"; + name = "mod_smacks/destroy_hibernating"; + callback = function () + session.log("debug", "Destroying session for hibernating too long"); + save_old_session(session); + session.resumption_token = nil; + sessionmanager.destroy_session(session, "Hibernating too long"); + sessions_expired(1); + end; + }); end); if session.conn then local conn = session.conn;