# HG changeset patch # User Kim Alvefur # Date 1658509790 -7200 # Node ID 5aafcf6a073046eeefd734933f9ba945325804f1 # Parent a2624315d30eb75f9b4acb9fa704053f93d7ba2e mod_storage_sql: Fix summary API with Postgres (fixes #1766) The ORDER BY and LIMIT clauses are not needed and don't even make much sense. This part was most likely a leftover from the :find method. Tested with sqlite and postgres 14 diff -r a2624315d30e -r 5aafcf6a0730 plugins/mod_storage_sql.lua --- a/plugins/mod_storage_sql.lua Fri Jul 22 18:32:45 2022 +0200 +++ b/plugins/mod_storage_sql.lua Fri Jul 22 19:09:50 2022 +0200 @@ -544,8 +544,7 @@ SELECT DISTINCT "with", COUNT(*), MIN("when"), MAX("when") FROM "prosodyarchive" WHERE %s - GROUP BY "with" - ORDER BY "sort_id" %s%s; + GROUP BY "with"; ]]; local args = { host, user or "", store, }; local where = { "\"host\" = ?", "\"user\" = ?", "\"store\" = ?", }; @@ -558,8 +557,7 @@ args[#args+1] = query.limit; end - sql_query = sql_query:format(t_concat(where, " AND "), query.reverse - and "DESC" or "ASC", query.limit and " LIMIT ?" or ""); + sql_query = sql_query:format(t_concat(where, " AND ")); return engine:select(sql_query, unpack(args)); end); if not ok then return ok, result end