# HG changeset patch # User Florian Zeitz # Date 1428085814 -7200 # Node ID 50eaefeec013c5ad2f434fddf2dc44482da8313e # Parent 78d1706982b21378d065fd45d6f039245592dc45 util-src/*.c: Per convention call luaL_error() as argument to return diff -r 78d1706982b2 -r 50eaefeec013 util-src/hashes.c --- a/util-src/hashes.c Fri Apr 03 19:31:05 2015 +0100 +++ b/util-src/hashes.c Fri Apr 03 20:30:14 2015 +0200 @@ -170,7 +170,7 @@ salt2 = malloc(salt_len + 4); if(salt2 == NULL) { - luaL_error(L, "Out of memory in scramHi"); + return luaL_error(L, "Out of memory in scramHi"); } memcpy(salt2, salt, salt_len); diff -r 78d1706982b2 -r 50eaefeec013 util-src/pposix.c --- a/util-src/pposix.c Fri Apr 03 19:31:05 2015 +0100 +++ b/util-src/pposix.c Fri Apr 03 20:30:14 2015 +0200 @@ -708,7 +708,7 @@ FILE* f = *(FILE**) luaL_checkudata(L, 1, LUA_FILEHANDLE); if(f == NULL) { - luaL_error(L, "attempt to use a closed file"); + return luaL_error(L, "attempt to use a closed file"); } offset = luaL_checkinteger(L, 2); diff -r 78d1706982b2 -r 50eaefeec013 util-src/signal.c --- a/util-src/signal.c Fri Apr 03 19:31:05 2015 +0100 +++ b/util-src/signal.c Fri Apr 03 20:30:14 2015 +0200 @@ -237,13 +237,14 @@ lua_gettable(L, -2); if(!lua_isnumber(L, -1)) { - luaL_error(L, "invalid signal string"); + return luaL_error(L, "invalid signal string"); } sig = (int) lua_tonumber(L, -1); lua_pop(L, 1); /* get rid of number we pushed */ } else { luaL_checknumber(L, 1); /* will always error, with good error msg */ + return luaL_error(L, "unreachable: invalid number was accepted"); } /* set handler */ @@ -313,7 +314,7 @@ lua_gettable(L, -2); if(!lua_isnumber(L, -1)) { - luaL_error(L, "invalid signal string"); + return luaL_error(L, "invalid signal string"); } ret = (lua_Number) raise((int) lua_tonumber(L, -1)); @@ -357,7 +358,7 @@ lua_gettable(L, -2); if(!lua_isnumber(L, -1)) { - luaL_error(L, "invalid signal string"); + return luaL_error(L, "invalid signal string"); } ret = (lua_Number) kill((int) lua_tonumber(L, 1),