# HG changeset patch
# User Kim Alvefur <zash@zash.se>
# Date 1569076156 -7200
# Node ID 4701415f5b0e3ad11334cb12d0217f47163c2895
# Parent  210278d5f99531e78351d79571b194f57b469008
mod_vcard_legacy: Don't owerwrite empty photo elements (fixes #1432)

diff -r 210278d5f995 -r 4701415f5b0e plugins/mod_vcard_legacy.lua
--- a/plugins/mod_vcard_legacy.lua	Sat Sep 21 15:20:50 2019 +0200
+++ b/plugins/mod_vcard_legacy.lua	Sat Sep 21 16:29:16 2019 +0200
@@ -300,13 +300,19 @@
 	if stanza.attr.type then return end
 	local pep_service = mod_pep.get_pep_service(username);
 
-	stanza:remove_children("x", "vcard-temp:x:update");
-	local x_update = st.stanza("x", { xmlns = "vcard-temp:x:update" }):tag("photo");
+	local x_update = stanza:get_child("x", "vcard-temp:x:update");
+	if not x_update then
+		x_update = st.stanza("x", { xmlns = "vcard-temp:x:update" }):tag("photo");
+		stanza:add_direct_child(x_update);
+	elseif x_update:get_child("photo") then
+		return; -- XEP implies that these should be left alone
+	else
+		x_update:tag("photo");
+	end
 	local ok, avatar_hash = pep_service:get_last_item("urn:xmpp:avatar:metadata", true);
 	if ok and avatar_hash then
 		x_update:text(avatar_hash);
 	end
-	stanza:add_direct_child(x_update);
 end
 
 module:hook("pre-presence/full", inject_xep153, 1);