# HG changeset patch
# User Kim Alvefur <zash@zash.se>
# Date 1708038936 -3600
# Node ID 41a587613a0e12b3d6e80437695aa50e17b182c7
# Parent  2374c7665d0baaa890c14c086e12d0b4e6bacc85
mod_smacks: Adjust buckets for resumption age statistic

Given that there are recommendations floating around recommending 24
hours session lifetime, having buckets up to 10 minutes wouldn't be
useful in that case.

Would be nice if we had some way to automatically assign suitable number
series for buckets, scaled to what the configuration might be.

diff -r 2374c7665d0b -r 41a587613a0e plugins/mod_smacks.lua
--- a/plugins/mod_smacks.lua	Thu Feb 15 20:28:14 2024 +0100
+++ b/plugins/mod_smacks.lua	Fri Feb 16 00:15:36 2024 +0100
@@ -39,7 +39,7 @@
 	"histogram",
 	"resumption_age", "seconds", "time the session had been hibernating at the time of a resumption",
 	{},
-	{buckets = { 0, 1, 2, 5, 10, 30, 60, 120, 300, 600 }}
+	{buckets = {0, 1, 12, 60, 360, 900, 1440, 3600, 14400, 86400}}
 ):with_labels();
 local sessions_expired = module:measure("sessions_expired", "counter");
 local sessions_started = module:measure("sessions_started", "counter");