# HG changeset patch
# User Kim Alvefur <zash@zash.se>
# Date 1638489563 -3600
# Node ID 3dd7886f9342da3f4a8f7345388623ae5942964c
# Parent  bbd3ac65640d2c973f7f6b8493f629092bbf3933
mod_smacks: Use function to construct error reply

Did error_reply() not exist when mod_smacks was first created?

diff -r bbd3ac65640d -r 3dd7886f9342 plugins/mod_smacks.lua
--- a/plugins/mod_smacks.lua	Fri Dec 03 00:11:31 2021 +0100
+++ b/plugins/mod_smacks.lua	Fri Dec 03 00:59:23 2021 +0100
@@ -395,17 +395,13 @@
 
 local function handle_unacked_stanzas(session)
 	local queue = session.outgoing_stanza_queue;
-	local error_attr = { type = "cancel" };
 	if #queue > 0 then
 		session.outgoing_stanza_queue = {};
 		for i=1,#queue do
 			if not module:fire_event("delivery/failure", { session = session, stanza = queue[i] }) then
 				if queue[i].attr.type ~= "error" then
-					local reply = st.reply(queue[i]);
+					local reply = st.error_reply(queue[i], "cancel", "recipient-unavailable");
 					if reply.attr.to ~= session.full_jid then
-						reply.attr.type = "error";
-						reply:tag("error", error_attr)
-							:tag("recipient-unavailable", {xmlns = "urn:ietf:params:xml:ns:xmpp-stanzas"});
 						core_process_stanza(session, reply);
 					end
 				end