# HG changeset patch
# User Kim Alvefur <zash@zash.se>
# Date 1650487314 -7200
# Node ID 3538366840095ee091d0b416c453b42c5a679de5
# Parent  ccbdebb43e23eec4b5b4ece41cc593c9388248bc
net.connect: Fix accumulation of connection attempt references

Connection attempts that failed the Happy Eyeballs race were not
unreferenced and would accumulate.

Tested by inspecting the 'pending_connections_map' after establishing
s2s with a s2s target where the IPv6 port has a -j DROP rule causing it
to time out and the IPv4 attempt wins the race.

Expected is that the losing connection stays around until net.server
timeouts kick in where it should be removed. The map table should tend
towards being empty during idle times.

diff -r ccbdebb43e23 -r 353836684009 net/connect.lua
--- a/net/connect.lua	Wed Apr 13 18:46:26 2022 +0100
+++ b/net/connect.lua	Wed Apr 20 22:41:54 2022 +0200
@@ -91,6 +91,7 @@
 		return;
 	end
 	p.conns[conn] = nil;
+	pending_connections_map[conn] = nil;
 	p.last_error = reason or "unknown reason";
 	p:log("debug", "Connection attempt failed: %s", p.last_error);
 	if p.connected then