# HG changeset patch
# User Kim Alvefur <zash@zash.se>
# Date 1638489722 -3600
# Node ID 1ea01660c79a20e31c4ae6e324da493e81c5a70c
# Parent  3dd7886f9342da3f4a8f7345388623ae5942964c
mod_smacks: Refactor, simplify, optimize

Since reply.attr.to will be the .attr.from of the input we can check
this earlier and avoid constructing the reply at all.

diff -r 3dd7886f9342 -r 1ea01660c79a plugins/mod_smacks.lua
--- a/plugins/mod_smacks.lua	Fri Dec 03 00:59:23 2021 +0100
+++ b/plugins/mod_smacks.lua	Fri Dec 03 01:02:02 2021 +0100
@@ -399,11 +399,9 @@
 		session.outgoing_stanza_queue = {};
 		for i=1,#queue do
 			if not module:fire_event("delivery/failure", { session = session, stanza = queue[i] }) then
-				if queue[i].attr.type ~= "error" then
+				if queue[i].attr.type ~= "error" and queue[i].attr.from ~= session.full_jid then
 					local reply = st.error_reply(queue[i], "cancel", "recipient-unavailable");
-					if reply.attr.to ~= session.full_jid then
-						core_process_stanza(session, reply);
-					end
+					core_process_stanza(session, reply);
 				end
 			end
 		end