# HG changeset patch
# User Kim Alvefur <zash@zash.se>
# Date 1658871873 -7200
# Node ID 1832b6c9c6edc2e53de26c6cde289bec1945cec3
# Parent  d580e6a57cbba9e601e4ca5afbabc689ffbaeb95
mod_bookmarks: Reduce error about not having bookmarks to debug (thanks tom)

This is happens if the account is new and doesn't have any bookmarks
yet, which is not a problem.

Rarely seen since most clients currently use the older version of
XEP-0084 stored in XEP-0049 rather than in PEP, but at least one
(Converse.js )does.

One scenario in which this would show up often is with Converse.js as a
guest chat using anonymous authentication, where all "accounts" would
always be new and not have any bookmarks. This scenario probably does
not need to have mod_bookmarks at all, but if enabled globally it would
likely become loaded onto the VirtualHost unless explicitly disabled.

diff -r d580e6a57cbb -r 1832b6c9c6ed plugins/mod_bookmarks.lua
--- a/plugins/mod_bookmarks.lua	Tue Jul 26 00:39:16 2022 +0200
+++ b/plugins/mod_bookmarks.lua	Tue Jul 26 23:44:33 2022 +0200
@@ -87,7 +87,11 @@
 	local service = mod_pep.get_pep_service(username);
 	local ok, ret = service:get_items(namespace, session.full_jid);
 	if not ok then
-		module:log("error", "Failed to retrieve PEP bookmarks of %s: %s", jid, ret);
+		if ret == "item-not-found" then
+			module:log("debug", "Got no PEP bookmarks item for %s, returning empty private bookmarks", jid);
+		else
+			module:log("error", "Failed to retrieve PEP bookmarks of %s: %s", jid, ret);
+		end
 		session.send(st.error_reply(stanza, "cancel", ret, "Failed to retrieve bookmarks from PEP"));
 		return true;
 	end
diff -r d580e6a57cbb -r 1832b6c9c6ed spec/scansion/empty_bookmarks.scs
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/spec/scansion/empty_bookmarks.scs	Tue Jul 26 23:44:33 2022 +0200
@@ -0,0 +1,27 @@
+# mod_scansion_record on host 'localhost' recording started 2022-07-26T21:39:55Z
+
+[Client] Romeo
+	password: password
+	jid: juliet@localhost/UaksS4M1xYZB
+
+-----
+
+Romeo connects
+
+Romeo sends:
+	<iq xml:lang='en' type='get' id='bNBJLtpIJXpq'>
+		<pubsub xmlns='http://jabber.org/protocol/pubsub'>
+			<items node='storage:bookmarks'/>
+		</pubsub>
+	</iq>
+
+Romeo receives:
+	<iq id='bNBJLtpIJXpq' type='error'>
+		<error type='cancel'>
+			<item-not-found xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
+		</error>
+	</iq>
+
+Romeo disconnects
+
+# recording ended on 2022-07-26T21:40:45Z