# HG changeset patch
# User Kim Alvefur <zash@zash.se>
# Date 1575755751 -3600
# Node ID 03ff1e614b4d58f66c042f5e26cc99a788f6ef9c
# Parent  02ccf2fbf00038fd72e00fb48af437b3ee6da6c0
mod_saslauth: Set a nicer bounce error explaining SASL EXTERNAL failures

Better than the previous string concatenation of SASL failure condition
and optional text sent by the remote server.

Would be nice to have a text per condition, other than the probably most
common 'not-authorized'.

diff -r 02ccf2fbf000 -r 03ff1e614b4d plugins/mod_saslauth.lua
--- a/plugins/mod_saslauth.lua	Sat Dec 07 22:51:43 2019 +0100
+++ b/plugins/mod_saslauth.lua	Sat Dec 07 22:55:51 2019 +0100
@@ -120,7 +120,10 @@
 
 module:hook_tag(xmlns_sasl, "failure", function (session, stanza) -- luacheck: ignore 212/stanza
 	session.log("debug", "No fallback from SASL EXTERNAL failure, giving up");
-	session:close(nil, session.external_auth_failure_reason);
+	session:close(nil, session.external_auth_failure_reason, errors.new({
+				type = "wait", condition = "remote-server-timeout",
+				text = "Could not authenticate to remote server",
+		}, { session = session, sasl_failure = session.external_auth_failure_reason, }));
 	return true;
 end, 90)