prosody
e385f3a06673
spec/scansion/muc_subject_issue_667.scs

Find changesets by keywords by author, files, the commit message, revision number or hash, or revset expression.

Software / code / prosody

File

spec/scansion/muc_subject_issue_667.scs @ 12995:e385f3a06673

moduleapi: Add 'peek' to :may() and new :could() helper to suppress logging The current method logs scary "access denied" messages on failure - this is generally very useful when debugging access control stuff, but in some cases the call is simply a check to see if someone *could* perform an action, even if they haven't requested it yet. One example is determining whether to show the user as an admin in disco. The 'peek' parameter, if true, will suppress such logging. The :could() method is just a simple helper that can make the calling code a bit more readable (suggested by Zash).
author Matthew Wild <mwild1@gmail.com>
date Sun, 26 Mar 2023 14:06:04 +0100
parent 9708:6507df6d2c55
child 13414:d54364746a7c
line wrap: on
line source

# #667 MUC message with subject and body SHALL NOT be interpreted as a subject change

[Client] Romeo
	password: password
	jid: romeo@localhost

-----

Romeo connects

# and creates a room
Romeo sends:
	<presence to="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

Romeo receives:
	<presence from="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc#user">
			<status code="201"/>
			<item affiliation="owner" role="moderator" jid="${Romeo's full JID}"/>
			<status code="110"/>
		</x>
	</presence>

# the default (empty) subject
Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost">
		<subject/>
	</message>

# this should be treated as a normal message
Romeo sends:
	<message to="issue667@conference.localhost" type="groupchat">
		<subject>Greetings</subject>
		<body>Hello everyone</body>
	</message>

Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<subject>Greetings</subject>
		<body>Hello everyone</body>
	</message>

# Resync
Romeo sends:
	<presence to="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

# Presences
Romeo receives:
	<presence from="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc#user">
			<item affiliation="owner" role="moderator" jid="${Romeo's full JID}"/>
			<status code="110"/>
		</x>
	</presence>

Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<subject>Greetings</subject>
		<body>Hello everyone</body>
	</message>

# the still empty subject
Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost">
		<subject/>
	</message>

# this is a subject change
Romeo sends:
	<message to="issue667@conference.localhost" type="groupchat">
		<subject>Something to talk about</subject>
	</message>

Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<subject>Something to talk about</subject>
	</message>

# a message without <subject>
Romeo sends:
	<message to="issue667@conference.localhost" type="groupchat">
		<body>Lorem ipsum dolor sit amet</body>
	</message>

Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<body>Lorem ipsum dolor sit amet</body>
	</message>

# Resync
Romeo sends:
	<presence to="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

# Presences
Romeo receives:
	<presence from="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc#user">
			<item affiliation="owner" role="moderator" jid="${Romeo's full JID}"/>
			<status code="110"/>
		</x>
	</presence>

# History
# These have delay tags but we ignore those for now
Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<subject>Greetings</subject>
		<body>Hello everyone</body>
	</message>

Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<body>Lorem ipsum dolor sit amet</body>
	</message>

# Finally, the topic
Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<subject>Something to talk about</subject>
	</message>

Romeo disconnects