File

MUC: Pass previous role to :publicise_occupant_status() whenever possible Currently there is what amounts to a hack in presence_broadcast.lib.lua to make it always broadcast presence with roles of "none". This is to ensure that if you previously saw available presence for someone, you will also see the unavailable presence (which always has role="none"). The correct approach is to take into account what the previous role was ( i.e. answer the question: "Was the available presence for this occupant a role for which presence broadcast is enabled?). The logic is already in place to do this correctly, but most call sites do not provide the previous role (prev_role argument) of the occupant, which causes it to not be used. In its place the hack to always broadcast presence of role="none" has allowed things to continue to work. The intention is that a subsequent commit will remove the unconditional broadcast of role="none".

+
−No 'to' attribute:
+
−	IQ:			Pass to appropriate handler
+
−	Presence:		Broadcast to contacts
+
−				- if initial presence, also send out presence probes
+
−					- if probe would be to local user, generate presence stanza for them
+
−	Message:		Route as if it is addressed to the bare JID of the sender
+
−
+
−To a local host:
+
−	IQ:			Pass to appropriate handler
+
−	Presence:		-
+
−	Message:		Deliver to admin?
+
−
+
−To local contact:
+
−	Bare JID:
+
−		IQ:		Pass to appropriate handler
+
−		Presence:	Broadcast to all resources
+
−		Message:	Route to 'best' resource
+
−	Full JID:
+
−		IQ:		Send to resource
+
−		Presence:	Send to resource
+
−		Message:	Send to resource
+
−	Full JID but resource not connected:
+
−		IQ:		Return service-unavailable
+
−		Message:	Handle same as if to bare JID
+
−		Presence:	Drop (unless type=subscribe[ed])
+
−
+
−To remote contact:
+
−	Initiate s2s connection if necessary
+
−	Send stanza across
+
−