File

HACKERS @ 10684:de607875d4bd

MUC: Pass previous role to :publicise_occupant_status() whenever possible Currently there is what amounts to a hack in presence_broadcast.lib.lua to make it always broadcast presence with roles of "none". This is to ensure that if you previously saw available presence for someone, you will also see the unavailable presence (which always has role="none"). The correct approach is to take into account what the previous role was ( i.e. answer the question: "Was the available presence for this occupant a role for which presence broadcast is enabled?). The logic is already in place to do this correctly, but most call sites do not provide the previous role (prev_role argument) of the occupant, which causes it to not be used. In its place the hack to always broadcast presence of role="none" has allowed things to continue to work. The intention is that a subsequent commit will remove the unconditional broadcast of role="none".
author Matthew Wild <mwild1@gmail.com>
date Thu, 12 Mar 2020 14:10:12 +0000
parent 9858:54147de1d1b1
line wrap: on
line source

Welcome hackers!

This project accepts and *encourages* contributions. If you would like to get 
involved you can join us on our mailing list and discussion rooms. More 
information on these at https://prosody.im/discuss

Patches are welcome, though before sending we would appreciate if you read 
docs/coding_style.md for guidelines on how to format your code, and other tips.

Documentation for developers can be found at https://prosody.im/doc/developers

Have fun :)