Software /
code /
prosody
File
spec/scansion/pep_nickname.scs @ 10571:cfeb0077c9e9
net.server_epoll: Avoid concatenating buffer with single item
Saves creating a string that'll be identical to buffer[1] anyways, as
well as a C function call. Depending on Lua version and length of the
string, this could be reusing an interned string, but a longer one would
probably be duplicated for no reason.
Having exactly one item in the buffer seems like it would be fairly
common, but I have not done an extensive study. If opportunistic writes
are enabled then it will be even more likely.
This special case could be optimized like this in table.concat but it
does not look like it is.
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Sat, 28 Dec 2019 06:18:58 +0100 |
parent | 9339:a35a636481c6 |
child | 11714:d783716103c1 |
line wrap: on
line source
# Publishing a nickname in PEP and receiving a notification [Client] Romeo jid: romeo@localhost/nJi7BeTR password: password ----- Romeo connects Romeo sends: <iq id="4" type="set"> <pubsub xmlns="http://jabber.org/protocol/pubsub"> <publish node="http://jabber.org/protocol/nick"> <item id="current"> <nickname xmlns="http://jabber.org/protocol/nick"/> </item> </publish> </pubsub> </iq> Romeo receives: <iq id="4" to="romeo@localhost/nJi7BeTR" type="result"> <pubsub xmlns="http://jabber.org/protocol/pubsub"> <publish node="http://jabber.org/protocol/nick"> <item id="current"/> </publish> </pubsub> </iq> Romeo sends: <presence> <c xmlns="http://jabber.org/protocol/caps" hash="sha-1" node="http://code.matthewwild.co.uk/clix/" ver="jC32N+FhQoLrZ7nNQtZK3aqR0Fk="/> </presence> Romeo receives: <iq id="disco" to="romeo@localhost/nJi7BeTR" from="romeo@localhost" type="get"> <query xmlns="http://jabber.org/protocol/disco#info" node="http://code.matthewwild.co.uk/clix/#jC32N+FhQoLrZ7nNQtZK3aqR0Fk="/> </iq> Romeo receives: <presence from="romeo@localhost/nJi7BeTR"> <c xmlns="http://jabber.org/protocol/caps" hash="sha-1" node="http://code.matthewwild.co.uk/clix/" ver="jC32N+FhQoLrZ7nNQtZK3aqR0Fk="/> </presence> Romeo sends: <iq id="disco" type="result" to="romeo@localhost"> <query xmlns="http://jabber.org/protocol/disco#info" node="http://code.matthewwild.co.uk/clix/#jC32N+FhQoLrZ7nNQtZK3aqR0Fk="> <identity type="console" name="clix" category="client"/> <feature var="http://jabber.org/protocol/disco#items"/> <feature var="http://jabber.org/protocol/disco#info"/> <feature var="http://jabber.org/protocol/caps"/> <feature var="http://jabber.org/protocol/nick+notify"/> </query> </iq> Romeo receives: <message type="headline" from="romeo@localhost" to="romeo@localhost/nJi7BeTR"> <event xmlns="http://jabber.org/protocol/pubsub#event"> <items node="http://jabber.org/protocol/nick"> <item id="current"> <nickname xmlns="http://jabber.org/protocol/nick"/> </item> </items> </event> </message> Romeo sends: <presence type="unavailable"/> Romeo disconnects