Software / code / prosody
File
plugins/muc/description.lib.lua @ 10571:cfeb0077c9e9
net.server_epoll: Avoid concatenating buffer with single item
Saves creating a string that'll be identical to buffer[1] anyways, as
well as a C function call. Depending on Lua version and length of the
string, this could be reusing an interned string, but a longer one would
probably be duplicated for no reason.
Having exactly one item in the buffer seems like it would be fairly
common, but I have not done an extensive study. If opportunistic writes
are enabled then it will be even more likely.
This special case could be optimized like this in table.concat but it
does not look like it is.
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Sat, 28 Dec 2019 06:18:58 +0100 |
| parent | 9034:1c709e3d2e5e |
line wrap: on
line source
-- Prosody IM -- Copyright (C) 2008-2010 Matthew Wild -- Copyright (C) 2008-2010 Waqas Hussain -- Copyright (C) 2014 Daurnimator -- -- This project is MIT/X11 licensed. Please see the -- COPYING file in the source package for more information. -- local function get_description(room) return room._data.description; end local function set_description(room, description) if description == "" then description = nil; end if get_description(room) == description then return false; end room._data.description = description; return true; end local function add_disco_form(event) table.insert(event.form, { name = "muc#roominfo_description"; label = "Description"; value = ""; }); event.formdata["muc#roominfo_description"] = get_description(event.room); end local function add_form_option(event) table.insert(event.form, { name = "muc#roomconfig_roomdesc"; type = "text-single"; label = "Description"; desc = "A brief description of the room"; value = get_description(event.room) or ""; }); end module:hook("muc-disco#info", add_disco_form); module:hook("muc-config-form", add_form_option, 100-2); module:hook("muc-config-submitted/muc#roomconfig_roomdesc", function(event) if set_description(event.room, event.value) then event.status_codes["104"] = true; end end); return { get = get_description; set = set_description; };