Software /
code /
prosody
File
spec/scansion/vcard_temp.scs @ 11405:ce8291e89d67
mod_http_file_share: Remove correct entries when not all expired files were deleted
If any of the expired files could not be deleted then we should not
forget about that, we should complain loudly and try again.
The code got this backwards and would have removed only the entries
referring to still existing files.
Test procedure:
1. Upload a file
2. chown root:root http_file_share/
3. In uploads.list, decrease 'when' enough to ensure expiry
4. Reload mod_http_file_share
5. Should see an error in the logs about failure to delete the file
6. Should see that the metadata in uploads.list is still there
7. chown http_file_share/ back to the previous owner
8. Reload mod_http_file_share
9. Should see logs about successful removal of expired file
10. Should see that the metadata in uploads.list is gone
11. Should see that the file was deleted
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Thu, 25 Feb 2021 23:58:08 +0100 |
parent | 9524:1f6f3b941eb1 |
child | 12967:53b0730093d8 |
line wrap: on
line source
# XEP-0054 vCard-temp writable and readable by anyone # mod_scansion_record on host 'localhost' recording started 2018-10-20T15:00:12Z [Client] Romeo jid: romeo@localhost password: password [Client] Juliet jid: juliet@localhost password: password ----- Romeo connects # Romeo sets his vCard # FN and N are required by the schema and mod_vcard_legacy will always inject them Romeo sends: <iq id="lx3" type="set"> <vCard xmlns="vcard-temp"> <FN>Romeo Montague</FN> <N> <FAMILY>Montague</FAMILY> <GIVEN>Romeo</GIVEN> <MIDDLE/> <PREFIX/> <SUFFIX/> </N> </vCard> </iq> Romeo receives: <iq type="result" id="lx3" to="${Romeo's full JID}"/> Romeo sends: <iq id="lx4" type="get"> <vCard xmlns="vcard-temp"/> </iq> Romeo receives: <iq type="result" id="lx4" to="${Romeo's full JID}"> <vCard xmlns="vcard-temp"> <FN>Romeo Montague</FN> <N> <FAMILY>Montague</FAMILY> <GIVEN>Romeo</GIVEN> <MIDDLE/> <PREFIX/> <SUFFIX/> </N> </vCard> </iq> Romeo disconnects Juliet connects Juliet sends: <iq type="get" id="lx3" to="romeo@localhost"> <vCard xmlns="vcard-temp"/> </iq> # Juliet can see Romeo's vCard since it's public Juliet receives: <iq type="result" from="romeo@localhost" id="lx3" to="${Juliet's full JID}"> <vCard xmlns="vcard-temp"> <FN>Romeo Montague</FN> <N> <FAMILY>Montague</FAMILY> <GIVEN>Romeo</GIVEN> <MIDDLE/> <PREFIX/> <SUFFIX/> </N> </vCard> </iq> Juliet disconnects # recording ended on 2018-10-20T15:02:14Z