Software / code / prosody
File
spec/scansion/muc_presence_probe.scs @ 12579:ca6a43fe0231 0.12
util.jsonschema: Fix validation to not assume presence of "type" field
MattJ reported a curious issue where validation did not work as
expected. Primarily that the "type" field was expected to be mandatory,
and thus leaving it out would result in no checks being performed.
This was likely caused by misreading during initial development.
Spent some time testing against
https://github.com/json-schema-org/JSON-Schema-Test-Suite.git and
discovered a multitude of issues, far too many to bother splitting into
separate commits.
More than half of them fail. Many because of features not implemented,
which have been marked NYI. For example, some require deep comparisons
e.g. when objects or arrays are present in enums fields.
Some because of quirks with how Lua differs from JavaScript, e.g. no
distinct array or object types. Tests involving fractional floating
point numbers. We're definitely not going to follow references to remote
resources. Or deal with UTF-16 sillyness. One test asserted that 1.0 is
an integer, where Lua 5.3+ will disagree.
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Fri, 08 Jul 2022 14:38:23 +0200 |
| parent | 11246:ab189e707705 |
line wrap: on
line source
# #1535 Let MUCs respond to presence probes [Client] Romeo jid: user@localhost password: password [Client] Juliet jid: user2@localhost password: password [Client] Mercutio jid: user3@localhost password: password ----- Romeo connects # Romeo joins the MUC Romeo sends: <presence to="room@conference.localhost/Romeo"> <x xmlns="http://jabber.org/protocol/muc"/> </presence> Romeo receives: <presence from='room@conference.localhost/Romeo'> <x xmlns='http://jabber.org/protocol/muc#user'> <status code='201'/> <item jid="${Romeo's full JID}" affiliation='owner' role='moderator'/> <status code='110'/> </x> </presence> Romeo receives: <message type='groupchat' from='room@conference.localhost'><subject/></message> # Disable presences for non-mods Romeo sends: <iq id='config1' to='room@conference.localhost' type='set'> <query xmlns='http://jabber.org/protocol/muc#owner'> <x xmlns='jabber:x:data' type='submit'> <field var='FORM_TYPE'> <value>http://jabber.org/protocol/muc#roomconfig</value> </field> <field var='muc#roomconfig_presencebroadcast'> <value>moderator</value> </field> </x> </query> </iq> Romeo receives: <iq id="config1" from="room@conference.localhost" type="result"> </iq> # Romeo probes himself Romeo sends: <presence to="room@conference.localhost/Romeo" type="probe"> <x xmlns="http://jabber.org/protocol/muc"/> </presence> Romeo receives: <presence from='room@conference.localhost/Romeo'> <x xmlns='http://jabber.org/protocol/muc#user'> <item jid="${Romeo's full JID}" affiliation='owner' role='moderator'/> </x> </presence> # Juliet tries to probe Romeo before joining the room Juliet connects Juliet sends: <presence to="room@conference.localhost/Romeo" type="probe"> <x xmlns="http://jabber.org/protocol/muc"/> </presence> Juliet receives: <presence from="room@conference.localhost/Romeo" type="error"> <error type="cancel"> <not-acceptable xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/> </error> </presence> # Juliet tries to probe Mercutio (who's not in the MUC) before joining the room Juliet sends: <presence to="room@conference.localhost/Mercutio" type="probe"> <x xmlns="http://jabber.org/protocol/muc"/> </presence> Juliet receives: <presence from="room@conference.localhost/Mercutio" type="error"> <error type="cancel"> <not-acceptable xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/> </error> </presence> # Juliet joins the room Juliet sends: <presence to="room@conference.localhost/Juliet"> <x xmlns="http://jabber.org/protocol/muc"/> </presence> Juliet receives: <presence from="room@conference.localhost/Romeo" /> Juliet receives: <presence from="room@conference.localhost/Juliet" /> # Romeo probes Juliet Romeo sends: <presence to="room@conference.localhost/Juliet" type="probe"> <x xmlns="http://jabber.org/protocol/muc"/> </presence> Romeo receives: <presence from='room@conference.localhost/Juliet'> <x xmlns='http://jabber.org/protocol/muc#user'> <item jid="${Juliet's full JID}" affiliation='none' role='participant'/> </x> </presence> # Mercutio tries to probe himself in a MUC before joining Mercutio connects Mercutio sends: <presence to="room@conference.localhost/Mercutio" type="probe"> <x xmlns="http://jabber.org/protocol/muc"/> </presence> Mercutio receives: <presence from="room@conference.localhost/Mercutio" type="error"> <error type="cancel"> <not-acceptable xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/> </error> </presence> # Romeo makes Mercutio a member and registers his nickname Romeo sends: <iq id='member1' to='room@conference.localhost' type='set'> <query xmlns='http://jabber.org/protocol/muc#admin'> <item affiliation='member' jid="${Mercutio's JID}" nick="Mercutio"/> </query> </iq> Romeo receives: <message from='room@conference.localhost'> <x xmlns='http://jabber.org/protocol/muc#user'> <item jid="${Mercutio's JID}" affiliation='member' /> </x> </message> Romeo receives: <iq from='room@conference.localhost' id='member1' type='result'/> # Romeo probes Mercutio, even though he's unavailable Romeo sends: <presence to="room@conference.localhost/Mercutio" type="probe"> <x xmlns="http://jabber.org/protocol/muc"/> </presence> Romeo receives: <presence from='room@conference.localhost/Mercutio' type="unavailable"> <x xmlns='http://jabber.org/protocol/muc#user'> <item nick="Mercutio" affiliation='member' role='none' jid="${Mercutio's JID}" /> </x> </presence>