prosody
ca6a43fe0231
spec/scansion/muc_nickname_robotface.scs

Find changesets by keywords by author, files, the commit message, revision number or hash, or revset expression.

Software / code / prosody

File

spec/scansion/muc_nickname_robotface.scs @ 12579:ca6a43fe0231 0.12

util.jsonschema: Fix validation to not assume presence of "type" field MattJ reported a curious issue where validation did not work as expected. Primarily that the "type" field was expected to be mandatory, and thus leaving it out would result in no checks being performed. This was likely caused by misreading during initial development. Spent some time testing against https://github.com/json-schema-org/JSON-Schema-Test-Suite.git and discovered a multitude of issues, far too many to bother splitting into separate commits. More than half of them fail. Many because of features not implemented, which have been marked NYI. For example, some require deep comparisons e.g. when objects or arrays are present in enums fields. Some because of quirks with how Lua differs from JavaScript, e.g. no distinct array or object types. Tests involving fractional floating point numbers. We're definitely not going to follow references to remote resources. Or deal with UTF-16 sillyness. One test asserted that 1.0 is an integer, where Lua 5.3+ will disagree.
author Kim Alvefur <zash@zash.se>
date Fri, 08 Jul 2022 14:38:23 +0200
parent 11411:f1fe37916501
line wrap: on
line source

# MUC: Prevent nicknames failing strict resourceprep

[Client] Romeo
	jid: user@localhost
	password: password

[Client] Roboteo
	jid: bot@localhost
	password: password

-----

Romeo connects

Romeo sends:
	<presence to="nobots@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

Romeo receives:
	<presence from='nobots@conference.localhost/Romeo'>
		<x xmlns='http://jabber.org/protocol/muc#user'>
			<status code='201'/>
			<item jid="${Romeo's full JID}" affiliation='owner' role='moderator'/>
			<status code='110'/>
		</x>
	</presence>

Romeo receives:
	<message type='groupchat' from='nobots@conference.localhost'><subject/></message>

Roboteo connects

Roboteo sends:
	<presence to="nobots@conference.localhost/🤖️">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

Roboteo receives:
	<presence type='error' from='nobots@conference.localhost/🤖'>
		<error by='nobots@conference.localhost' type='modify'>
			<jid-malformed xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
			<text xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>Nickname must pass strict validation</text>
		</error>
	</presence>