Software /
code /
prosody
File
spec/scansion/muc_subject_issue_667.scs @ 13182:c48ae06e24d6
util.datamanager: Fix indexing first item if not at the very start
If the first item does not start at position 0 then the index function
produces a phantom first entry covering position zero until where the
real first item starts. When using the index, this would make it either
appear as the first item was missing or cause an off-by-one issue with
remaining items.
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Mon, 10 Jul 2023 17:19:05 +0200 |
parent | 9708:6507df6d2c55 |
line wrap: on
line source
# #667 MUC message with subject and body SHALL NOT be interpreted as a subject change [Client] Romeo password: password jid: romeo@localhost ----- Romeo connects # and creates a room Romeo sends: <presence to="issue667@conference.localhost/Romeo"> <x xmlns="http://jabber.org/protocol/muc"/> </presence> Romeo receives: <presence from="issue667@conference.localhost/Romeo"> <x xmlns="http://jabber.org/protocol/muc#user"> <status code="201"/> <item affiliation="owner" role="moderator" jid="${Romeo's full JID}"/> <status code="110"/> </x> </presence> # the default (empty) subject Romeo receives: <message type="groupchat" from="issue667@conference.localhost"> <subject/> </message> # this should be treated as a normal message Romeo sends: <message to="issue667@conference.localhost" type="groupchat"> <subject>Greetings</subject> <body>Hello everyone</body> </message> Romeo receives: <message type="groupchat" from="issue667@conference.localhost/Romeo"> <subject>Greetings</subject> <body>Hello everyone</body> </message> # Resync Romeo sends: <presence to="issue667@conference.localhost/Romeo"> <x xmlns="http://jabber.org/protocol/muc"/> </presence> # Presences Romeo receives: <presence from="issue667@conference.localhost/Romeo"> <x xmlns="http://jabber.org/protocol/muc#user"> <item affiliation="owner" role="moderator" jid="${Romeo's full JID}"/> <status code="110"/> </x> </presence> Romeo receives: <message type="groupchat" from="issue667@conference.localhost/Romeo"> <subject>Greetings</subject> <body>Hello everyone</body> </message> # the still empty subject Romeo receives: <message type="groupchat" from="issue667@conference.localhost"> <subject/> </message> # this is a subject change Romeo sends: <message to="issue667@conference.localhost" type="groupchat"> <subject>Something to talk about</subject> </message> Romeo receives: <message type="groupchat" from="issue667@conference.localhost/Romeo"> <subject>Something to talk about</subject> </message> # a message without <subject> Romeo sends: <message to="issue667@conference.localhost" type="groupchat"> <body>Lorem ipsum dolor sit amet</body> </message> Romeo receives: <message type="groupchat" from="issue667@conference.localhost/Romeo"> <body>Lorem ipsum dolor sit amet</body> </message> # Resync Romeo sends: <presence to="issue667@conference.localhost/Romeo"> <x xmlns="http://jabber.org/protocol/muc"/> </presence> # Presences Romeo receives: <presence from="issue667@conference.localhost/Romeo"> <x xmlns="http://jabber.org/protocol/muc#user"> <item affiliation="owner" role="moderator" jid="${Romeo's full JID}"/> <status code="110"/> </x> </presence> # History # These have delay tags but we ignore those for now Romeo receives: <message type="groupchat" from="issue667@conference.localhost/Romeo"> <subject>Greetings</subject> <body>Hello everyone</body> </message> Romeo receives: <message type="groupchat" from="issue667@conference.localhost/Romeo"> <body>Lorem ipsum dolor sit amet</body> </message> # Finally, the topic Romeo receives: <message type="groupchat" from="issue667@conference.localhost/Romeo"> <subject>Something to talk about</subject> </message> Romeo disconnects