Software /
code /
prosody
File
spec/util_poll_spec.lua @ 12659:c0eea4f6c739
usermanager: Add back temporary is_admin to warn about deprecated API usage
Goal: Introduce role-auth with minimal disruption
is_admin() is unsafe in a system with per-session permissions, so it has been
deprecated.
Roll-out approach:
1) First, log a warning when is_admin() is used. It should continue to
function normally, backed by the new role API. Nothing is really using
per-session authz yet, so there is minimal security concern.
The 'strict_deprecate_is_admin' global setting can be set to 'true' to
force a hard failure of is_admin() attempts (it will log an error and
always return false).
2) In some time (at least 1 week), but possibly longer depending on the number
of affected deployments: switch 'strict_deprecate_is_admin' to 'true' by
default. It can still be disabled for systems that need it.
3) Further in the future, before the next release, the option will be removed
and is_admin() will be permanently disabled.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Mon, 15 Aug 2022 15:25:07 +0100 |
parent | 12400:728d1c1dc7db |
line wrap: on
line source
describe("util.poll", function() local poll; setup(function() poll = require "util.poll"; end); it("loads", function() assert.is_table(poll); assert.is_function(poll.new); assert.is_string(poll.api); end); describe("new", function() local p; setup(function() p = poll.new(); end) it("times out", function () local fd, err = p:wait(0); assert.falsy(fd); assert.equal("timeout", err); end); it("works", function() -- stdout should be writable, right? assert.truthy(p:add(1, false, true)); local fd, r, w = p:wait(1); assert.is_number(fd); assert.is_boolean(r); assert.is_boolean(w); assert.equal(1, fd); assert.falsy(r); assert.truthy(w); assert.truthy(p:del(1)); end); end) end);