File

spec/util_multitable_spec.lua @ 12659:c0eea4f6c739

usermanager: Add back temporary is_admin to warn about deprecated API usage Goal: Introduce role-auth with minimal disruption is_admin() is unsafe in a system with per-session permissions, so it has been deprecated. Roll-out approach: 1) First, log a warning when is_admin() is used. It should continue to function normally, backed by the new role API. Nothing is really using per-session authz yet, so there is minimal security concern. The 'strict_deprecate_is_admin' global setting can be set to 'true' to force a hard failure of is_admin() attempts (it will log an error and always return false). 2) In some time (at least 1 week), but possibly longer depending on the number of affected deployments: switch 'strict_deprecate_is_admin' to 'true' by default. It can still be disabled for systems that need it. 3) Further in the future, before the next release, the option will be removed and is_admin() will be permanently disabled.
author Matthew Wild <mwild1@gmail.com>
date Mon, 15 Aug 2022 15:25:07 +0100
parent 8236:4878e4159e12
line wrap: on
line source


local multitable = require "util.multitable";

describe("util.multitable", function()
	describe("#new()", function()
		it("should create a multitable", function()
			local mt = multitable.new();
			assert.is_table(mt, "Multitable is a table");
			assert.is_function(mt.add, "Multitable has method add");
			assert.is_function(mt.get, "Multitable has method get");
			assert.is_function(mt.remove, "Multitable has method remove");
		end);
	end);

	describe("#get()", function()
		it("should allow getting correctly", function()
			local function has_items(list, ...)
				local should_have = {};
				if select('#', ...) > 0 then
					assert.is_table(list, "has_items: list is table", 3);
				else
					assert.is.falsy(list and #list > 0, "No items, and no list");
					return true, "has-all";
				end
				for n=1,select('#', ...) do should_have[select(n, ...)] = true; end
				for _, item in ipairs(list) do
					if not should_have[item] then return false, "too-many"; end
					should_have[item] = nil;
				end
				if next(should_have) then
					return false, "not-enough";
				end
				return true, "has-all";
			end
			local function assert_has_all(message, list, ...)
				return assert.are.equal(select(2, has_items(list, ...)), "has-all", message or "List has all expected items, and no more", 2);
			end

			local mt = multitable.new();

			local trigger1, trigger2, trigger3 = {}, {}, {};
			local item1, item2, item3 = {}, {}, {};

			assert_has_all("Has no items with trigger1", mt:get(trigger1));


			mt:add(1, 2, 3, item1);

			assert_has_all("Has item1 for 1, 2, 3", mt:get(1, 2, 3), item1);
		end);
	end);

	-- Doesn't support nil
	--[[	mt:add(nil, item1);
		mt:add(nil, item2);
		mt:add(nil, item3);

		assert_has_all("Has all items with (nil)", mt:get(nil), item1, item2, item3);
	]]
end);