Software /
code /
prosody
File
spec/util_datamanager_spec.lua @ 12659:c0eea4f6c739
usermanager: Add back temporary is_admin to warn about deprecated API usage
Goal: Introduce role-auth with minimal disruption
is_admin() is unsafe in a system with per-session permissions, so it has been
deprecated.
Roll-out approach:
1) First, log a warning when is_admin() is used. It should continue to
function normally, backed by the new role API. Nothing is really using
per-session authz yet, so there is minimal security concern.
The 'strict_deprecate_is_admin' global setting can be set to 'true' to
force a hard failure of is_admin() attempts (it will log an error and
always return false).
2) In some time (at least 1 week), but possibly longer depending on the number
of affected deployments: switch 'strict_deprecate_is_admin' to 'true' by
default. It can still be disabled for systems that need it.
3) Further in the future, before the next release, the option will be removed
and is_admin() will be permanently disabled.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Mon, 15 Aug 2022 15:25:07 +0100 |
parent | 11370:7c2ef5a1ec9c |
line wrap: on
line source
describe("util.datamanager", function() local dm; setup(function() dm = require "util.datamanager"; dm.set_data_path("./data"); end); describe("keyvalue", function() local data = {hello = "world"}; do local ok, err = dm.store("keyval-user", "datamanager.test", "testdata", data); assert.truthy(ok, err); end do local read, err = dm.load("keyval-user", "datamanager.test", "testdata") assert.same(data, read, err); end do local ok, err = dm.store("keyval-user", "datamanager.test", "testdata", nil); assert.truthy(ok, err); end do local read, err = dm.load("keyval-user", "datamanager.test", "testdata") assert.is_nil(read, err); end end) describe("lists", function() do local ok, err = dm.list_store("list-user", "datamanager.test", "testdata", {}); assert.truthy(ok, err); end do local nothing, err = dm.list_load("list-user", "datamanager.test", "testdata"); assert.is_nil(nothing, err); assert.is_nil(err); end do local ok, err = dm.list_append("list-user", "datamanager.test", "testdata", {id = 1}); assert.truthy(ok, err); end do local ok, err = dm.list_append("list-user", "datamanager.test", "testdata", {id = 2}); assert.truthy(ok, err); end do local ok, err = dm.list_append("list-user", "datamanager.test", "testdata", {id = 3}); assert.truthy(ok, err); end do local list, err = dm.list_load("list-user", "datamanager.test", "testdata"); assert.same(list, {{id = 1}; {id = 2}; {id = 3}}, err); end do local ok, err = dm.list_store("list-user", "datamanager.test", "testdata", {}); assert.truthy(ok, err); end do local nothing, err = dm.list_load("list-user", "datamanager.test", "testdata"); assert.is_nil(nothing, err); assert.is_nil(err); end end) end)