Software /
code /
prosody
File
plugins/muc/description.lib.lua @ 12659:c0eea4f6c739
usermanager: Add back temporary is_admin to warn about deprecated API usage
Goal: Introduce role-auth with minimal disruption
is_admin() is unsafe in a system with per-session permissions, so it has been
deprecated.
Roll-out approach:
1) First, log a warning when is_admin() is used. It should continue to
function normally, backed by the new role API. Nothing is really using
per-session authz yet, so there is minimal security concern.
The 'strict_deprecate_is_admin' global setting can be set to 'true' to
force a hard failure of is_admin() attempts (it will log an error and
always return false).
2) In some time (at least 1 week), but possibly longer depending on the number
of affected deployments: switch 'strict_deprecate_is_admin' to 'true' by
default. It can still be disabled for systems that need it.
3) Further in the future, before the next release, the option will be removed
and is_admin() will be permanently disabled.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Mon, 15 Aug 2022 15:25:07 +0100 |
parent | 9034:1c709e3d2e5e |
line wrap: on
line source
-- Prosody IM -- Copyright (C) 2008-2010 Matthew Wild -- Copyright (C) 2008-2010 Waqas Hussain -- Copyright (C) 2014 Daurnimator -- -- This project is MIT/X11 licensed. Please see the -- COPYING file in the source package for more information. -- local function get_description(room) return room._data.description; end local function set_description(room, description) if description == "" then description = nil; end if get_description(room) == description then return false; end room._data.description = description; return true; end local function add_disco_form(event) table.insert(event.form, { name = "muc#roominfo_description"; label = "Description"; value = ""; }); event.formdata["muc#roominfo_description"] = get_description(event.room); end local function add_form_option(event) table.insert(event.form, { name = "muc#roomconfig_roomdesc"; type = "text-single"; label = "Description"; desc = "A brief description of the room"; value = get_description(event.room) or ""; }); end module:hook("muc-disco#info", add_disco_form); module:hook("muc-config-form", add_form_option, 100-2); module:hook("muc-config-submitted/muc#roomconfig_roomdesc", function(event) if set_description(event.room, event.value) then event.status_codes["104"] = true; end end); return { get = get_description; set = set_description; };